From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2HQF-00080L-T0 for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:42:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2HQC-0007EA-MH for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:42:39 -0500 Received: from mr213138.mail.yeah.net ([223.252.213.138]:56240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2HQC-0007DP-9X for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:42:36 -0500 References: <1448357149-17572-1-git-send-email-zhang.zhanghailiang@huawei.com> <1448357149-17572-36-git-send-email-zhang.zhanghailiang@huawei.com> From: Yang Hongyang Message-ID: <565841A4.8020302@easystack.cn> Date: Fri, 27 Nov 2015 19:42:28 +0800 MIME-Version: 1.0 In-Reply-To: <1448357149-17572-36-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH COLO-Frame v11 35/39] filter-buffer: Accept zero interval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Jason Wang , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com On 2015=E5=B9=B411=E6=9C=8824=E6=97=A5 17:25, zhanghailiang wrote: > For default buffer filter, its 'interval' value is zero, > so here we should accept zero interval. > > Signed-off-by: zhanghailiang > Cc: Jason Wang > Cc: Yang Hongyang Reviewed-by: Yang Hongyang > --- > v11: > - Add comment > v10: > - new patch > --- > net/filter-buffer.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/net/filter-buffer.c b/net/filter-buffer.c > index 195af68..5cab4fc 100644 > --- a/net/filter-buffer.c > +++ b/net/filter-buffer.c > @@ -116,16 +116,6 @@ static void filter_buffer_setup(NetFilterState *nf= , Error **errp) > FilterBufferState *s =3D FILTER_BUFFER(nf); > char *path =3D object_get_canonical_path_component(OBJECT(nf)); > > - /* > - * We may want to accept zero interval when VM FT solutions like M= C > - * or COLO use this filter to release packets on demand. > - */ > - if (!s->interval) { > - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval", > - "a non-zero interval"); > - return; > - } > - > s->incoming_queue =3D qemu_new_net_queue(qemu_netfilter_pass_to_n= ext, nf); > s->is_default =3D !strcmp(path, "nop"); > if (s->interval) { > --=20 Thanks, Yang