From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2MFh-0002iD-DZ for qemu-devel@nongnu.org; Fri, 27 Nov 2015 11:52:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2MFg-0007Ep-GZ for qemu-devel@nongnu.org; Fri, 27 Nov 2015 11:52:05 -0500 References: <1448294400-476-1-git-send-email-kwolf@redhat.com> <1448294400-476-2-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56588A2C.5020106@redhat.com> Date: Fri, 27 Nov 2015 17:51:56 +0100 MIME-Version: 1.0 In-Reply-To: <1448294400-476-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JH2AeAP0UddXfAwubTaBa3pDlBcVBXvjI" Subject: Re: [Qemu-devel] [PATCH v2 01/21] qcow2: Add .bdrv_join_options callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JH2AeAP0UddXfAwubTaBa3pDlBcVBXvjI Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 23.11.2015 16:59, Kevin Wolf wrote: > qcow2 accepts a few driver-specific options that overlap semantically > (e.g. "overlap-check" is an alias of "overlap-check.template", and any > missing cache size option is derived from the given ones). >=20 > When bdrv_reopen() merges the set of updated options with left out > options that should be kept at their old value, we need to consider thi= s > and filter out any duplicates (which would generally cause errors > because new and old value would contradict each other). >=20 > This patch adds a .bdrv_join_options callback to BlockDriver and > implements it for qcow2. >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 47 +++++++++++++++++++++++++++++++++++++++= ++++++++ > include/block/block_int.h | 1 + > 2 files changed, 48 insertions(+) Reviewed-by: Max Reitz --JH2AeAP0UddXfAwubTaBa3pDlBcVBXvjI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWWIosAAoJEDuxQgLoOKytZxQH/i/szaMBklpWG4UFhK4/zwm8 COr21vK/aYYVQ3kwk1mX/1IHxTds5R13fiQ48MHlSqi/XgirnQr034UqOlgXz02h ZgvXG3vq54LBrHB5Scp/MOsPrNmgqXA8WYP2v++lWQSaUH3fq3wbU89KxSYMBQ5R Dhx0fLpfESwZdFXkDPRBjv8Ku/A3lPLm+ojs+CiiQxza5hSq8TV+Wu+MnZDBaS7E vyk793sfBj3icKFJVs+CojpHEssFysCIYQPDkrPLwLKJlXY5A6z1bxcnR5vSRilu rvLs8ZtHy4DyACfF20hghHJCJqV4Sdq9HHCkuUWWHS39AdeS/OVyE5qMmikjR6Q= =duYV -----END PGP SIGNATURE----- --JH2AeAP0UddXfAwubTaBa3pDlBcVBXvjI--