From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2MJp-0005gv-Cn for qemu-devel@nongnu.org; Fri, 27 Nov 2015 11:56:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2MJo-0000SS-K9 for qemu-devel@nongnu.org; Fri, 27 Nov 2015 11:56:21 -0500 References: <1448294400-476-1-git-send-email-kwolf@redhat.com> <1448294400-476-3-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56588B2C.30108@redhat.com> Date: Fri, 27 Nov 2015 17:56:12 +0100 MIME-Version: 1.0 In-Reply-To: <1448294400-476-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bnMHwGPXqgsdtMi0w32UrEKsMMJv8j8BA" Subject: Re: [Qemu-devel] [PATCH v2 02/21] block: Fix reopen with semantically overlapping options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bnMHwGPXqgsdtMi0w32UrEKsMMJv8j8BA Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 23.11.2015 16:59, Kevin Wolf wrote: > This fixes bdrv_reopen() calls like the following one: >=20 > qemu-io -c 'open -o overlap-check.template=3Dall /tmp/test.qcow2' \= > -c 'reopen -o overlap-check=3Dnone' >=20 > The approach taken so far would result in an options QDict that has bot= h > "overlap-check.template=3Dall" and "overlap-check=3Dnone", which obviou= sly > conflicts. In this case, the old option should be overridden by the > newly specified option. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz --bnMHwGPXqgsdtMi0w32UrEKsMMJv8j8BA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWWIssAAoJEDuxQgLoOKytWJwIAK0NMDV5iA0OVb7IJuQYQ6K4 15jQyciYBBpYWb6EJakh6s5vX4mTy1AN2bUAT+SncD13utsYoHywN6IuXon/W4GU mA9ERyWsEb14SFL+AuUsUH42eGM7FJtlyZzK7X/5MHVXnYKEVtvTUfAWIIkBSSDA 2LOJtStJ9SEXtNX/o2AuA+R6k1ZRE8/1KLan5knWmlPqca48MBPUXxk0FUyJLRbq H/lBdP8GdZqGH2cS+mplUILYNSZcZu9okp2W52hZ3pP+tBfGIyUjEsTUxxP/WEDF cSqxgi5H32QR7QMjxQh1XhbXfQqi+tTOSUgGecqN+6QLj9RrexPjZehLRXxCv6U= =1og3 -----END PGP SIGNATURE----- --bnMHwGPXqgsdtMi0w32UrEKsMMJv8j8BA--