On 23.11.2015 16:59, Kevin Wolf wrote: > Creating an empty drive while specifying 'format' doesn't make sense. > The specified format driver would simply be ignored. > > Make a set 'format' option an indication that a non-empty drive should > be created. This makes 'format' consistent with 'driver' and allows > using it with a block driver that doesn't need any other options (like > null-co/null-aio). > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 5 +---- > tests/qemu-iotests/iotests.py | 2 +- > 2 files changed, 2 insertions(+), 5 deletions(-) Besides the failing make check, the patch looks good. Max