From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0tmZ-0004ia-H1 for qemu-devel@nongnu.org; Mon, 04 Mar 2019 15:01:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0tmY-0005nW-Iz for qemu-devel@nongnu.org; Mon, 04 Mar 2019 15:01:51 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:39882) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h0tmY-0005ms-Ay for qemu-devel@nongnu.org; Mon, 04 Mar 2019 15:01:50 -0500 Received: by mail-wm1-f68.google.com with SMTP id z84so368972wmg.4 for ; Mon, 04 Mar 2019 12:01:50 -0800 (PST) References: <20190304151827.1813-1-davidkiarie4@gmail.com> <20190304151827.1813-2-davidkiarie4@gmail.com> <50ec8aca-252e-792f-9a9a-a5dc606eca9c@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <5659a8f6-d9d1-53b7-5be4-7460590c65d9@redhat.com> Date: Mon, 4 Mar 2019 21:01:47 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/1] update copyright notice List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Kiarie Cc: QEMU Developers , "Michael S. Tsirkin" , Jan Kiszka , Peter Xu , Paolo Bonzini , Richard Henderson Hi David, On 3/4/19 8:29 PM, David Kiarie wrote: > > > On Mon, Mar 4, 2019 at 10:20 PM David Kiarie > wrote: > > > > On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé > > wrote: > > On 3/4/19 4:18 PM, David Kiarie wrote: > > Signed-off-by: David Kiarie > > > Reviewed-by: Philippe Mathieu-Daudé > > > > would i be wrong to say this patch received unwarranted scrutiny > from you, Philippe? > > > i mean, given you have never been involved in any IOMMU work, i wouldn't > expect that you're in a position to asking questions about the copyright. IANAL and I have no knowledge of IOMMU indeed. I noticed first this patch is sent from the same email used in this copyright notice, then the patch content merged in commit d29a09ca684 was accepted in 2016 with a copyright date of 2015, hence your copyright modification looks correct to me. Regards, Philippe. >   > > > > > --- > >  hw/i386/amd_iommu.c | 2 +- > >  hw/i386/amd_iommu.h | 2 +- > >  2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c > > index 8ad707a..6eabdf9 100644 > > --- a/hw/i386/amd_iommu.c > > +++ b/hw/i386/amd_iommu.c > > @@ -2,7 +2,7 @@ > >   * QEMU emulation of AMD IOMMU (AMD-Vi) > >   * > >   * Copyright (C) 2011 Eduard - Gabriel Munteanu > > - * Copyright (C) 2015 David Kiarie, > > > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > >   * > >   * This program is free software; you can redistribute it > and/or modify > >   * it under the terms of the GNU General Public License as > published by > > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h > > index c52886f..0ff9095 100644 > > --- a/hw/i386/amd_iommu.h > > +++ b/hw/i386/amd_iommu.h > > @@ -2,7 +2,7 @@ > >   * QEMU emulation of an AMD IOMMU (AMD-Vi) > >   * > >   * Copyright (C) 2011 Eduard - Gabriel Munteanu > > - * Copyright (C) 2015 David Kiarie, > > > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > >   * > >   * This program is free software; you can redistribute it > and/or modify > >   * it under the terms of the GNU General Public License as > published by > > >