From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCHv6] 27/28] build: convert CONFIG_COMPAT to Kconfig Date: Mon, 30 Nov 2015 08:18:59 -0700 Message-ID: <565C76F302000078000BA4F8@prv-mh.provo.novell.com> References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com> <1448387538-12208-28-git-send-email-cardoe@cardoe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1448387538-12208-28-git-send-email-cardoe@cardoe.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Doug Goldstein Cc: Andrew Cooper , Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>> On 24.11.15 at 18:52, wrote: > --- > xen/arch/x86/Kconfig | 7 +++++++ > 1 file changed, 7 insertions(+) This can't be complete - you ought to be deleting the current definition. > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -25,6 +25,13 @@ config ARCH_DEFCONFIG > > menu "Architecture Features" > > +config COMPAT > + def_bool y > + help > + 32-bit interface support on 64-bit Xen which is used for both > + HVM and PV guests. HVMLoader makes 32-bit hypercalls irrespective > + of the destination runmode of the guest. I also don't think help text is very useful here, as it won't appear anywhere (and due to the hvmloader needs it's also not very likely to become a user selectable option going forward). Jan