From: Richard Henderson <rth@twiddle.net>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/7] target-i386: MMReg struct cleanup
Date: Mon, 30 Nov 2015 10:54:48 -0800 [thread overview]
Message-ID: <565C9B78.8010405@twiddle.net> (raw)
In-Reply-To: <1448907702-24815-1-git-send-email-ehabkost@redhat.com>
On 11/30/2015 10:21 AM, Eduardo Habkost wrote:
> This is an attempt to cleanup the MMXReg/XMMReg structs and make
> their names, fields and usage consistent.
>
> The last 2 patches use a bit of macro magic to generate the union
> definitions and ensure type safety when using the field helper
> macros, and I am sending them as RFCs.
It all looks ok, as far as it goes.
Though I wonder if it wouldn't be better to reorg everything to work akin to
the aarch64 method -- process everything in 64-bit chunks, via TCG registers,
rather than via pointers to structures.
That would much easier let mmx and sse (and avx2 and avx512) use the same set
of helpers, with much less need for all this macro-ization in the first place.
r~
prev parent reply other threads:[~2015-11-30 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 18:21 [Qemu-devel] [PATCH 0/7] target-i386: MMReg struct cleanup Eduardo Habkost
2015-11-30 18:21 ` [Qemu-devel] [PATCH 1/7] target-i386/ops_sse.h: Use MMX_Q macro Eduardo Habkost
2015-11-30 18:21 ` [Qemu-devel] [PATCH 2/7] target-i386: Use a _q array on MMXReg too Eduardo Habkost
2015-11-30 18:21 ` [Qemu-devel] [PATCH 3/7] target-i386: Rename struct XMMReg to ZMMReg Eduardo Habkost
2015-11-30 18:21 ` [Qemu-devel] [PATCH 4/7] target-i386: Rename XMM_[BWLSDQ] helpers to ZMM_* Eduardo Habkost
2015-11-30 18:21 ` [Qemu-devel] [PATCH 5/7] target-i386: Define MMXReg._d field Eduardo Habkost
2015-11-30 18:21 ` [Qemu-devel] [PATCH 6/7] [RFC] target-i386: Define MMREG_UNION macro Eduardo Habkost
2015-12-01 11:00 ` Paolo Bonzini
2015-11-30 18:21 ` [Qemu-devel] [PATCH 7/7] [RFC] target-i386: Add suffixes to MMReg struct fields Eduardo Habkost
2015-11-30 18:54 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565C9B78.8010405@twiddle.net \
--to=rth@twiddle.net \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.