From mboxrd@z Thu Jan 1 00:00:00 1970 From: YOSHIFUJI Hideaki Subject: Re: [PATCH net] ipv6: kill sk_dst_lock Date: Tue, 1 Dec 2015 10:44:39 +0900 Message-ID: <565CFB87.9060402@miraclelinux.com> References: <1448730683.24696.94.camel@edumazet-glaptop2.roam.corp.google.com> <1448731434.24696.97.camel@edumazet-glaptop2.roam.corp.google.com> <1448854142.24696.109.camel@edumazet-glaptop2.roam.corp.google.com> <1448901315.24696.127.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: hideaki.yoshifuji@miraclelinux.com, Vlad Yasevich , Hideaki YOSHIFUJI , netdev , Eric Dumazet To: Eric Dumazet , Dmitry Vyukov , "David S. Miller" Return-path: Received: from mail-pa0-f49.google.com ([209.85.220.49]:35823 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbbLABoo (ORCPT ); Mon, 30 Nov 2015 20:44:44 -0500 Received: by pacej9 with SMTP id ej9so203373185pac.2 for ; Mon, 30 Nov 2015 17:44:43 -0800 (PST) In-Reply-To: <1448901315.24696.127.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi, Eric Dumazet wrote: > diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h > index 2bfb2ad2fab1..877f682989b8 100644 > --- a/include/net/ip6_route.h > +++ b/include/net/ip6_route.h > @@ -133,27 +133,18 @@ void rt6_clean_tohost(struct net *net, struct in6_addr *gateway); > /* > * Store a destination cache entry in a socket > */ > -static inline void __ip6_dst_store(struct sock *sk, struct dst_entry *dst, > - const struct in6_addr *daddr, > - const struct in6_addr *saddr) > +static inline void ip6_dst_store(struct sock *sk, struct dst_entry *dst, > + const struct in6_addr *daddr, > + const struct in6_addr *saddr) > { > struct ipv6_pinfo *np = inet6_sk(sk); > - struct rt6_info *rt = (struct rt6_info *) dst; > > + np->dst_cookie = rt6_get_cookie((struct rt6_info *)dst); > sk_setup_caps(sk, dst); > np->daddr_cache = daddr; > #ifdef CONFIG_IPV6_SUBTREES > np->saddr_cache = saddr; > #endif > - np->dst_cookie = rt6_get_cookie(rt); > -} > - I believe you do not have to change function inside, right? -- Hideaki Yoshifuji Technical Division, MIRACLE LINUX CORPORATION