From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH] drm: Fix an unwanted master inheritance Date: Tue, 1 Dec 2015 12:58:13 +0100 Message-ID: <565D8B55.7090400@vmware.com> References: <1448887461-3175-1-git-send-email-thellstrom@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com [208.91.2.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 650B86E81D for ; Tue, 1 Dec 2015 03:58:21 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov , Thomas Hellstrom Cc: pv-drivers@vmware.com, linux-graphics-maintainer@vmware.com, ML dri-devel List-Id: dri-devel@lists.freedesktop.org T24gMTIvMDEvMjAxNSAxMTo1NyBBTSwgRW1pbCBWZWxpa292IHdyb3RlOgo+IEhpIFRob21hcywK Pgo+IFNvbWV0aGluZyBkb2Vzbid0IGZlZWwgcXVpdGUgcmlnaHQsIHBsZWFzZSByZWFkIG9uLgo+ Cj4gT24gMzAgTm92ZW1iZXIgMjAxNSBhdCAxMjo0NCwgVGhvbWFzIEhlbGxzdHJvbSA8dGhlbGxz dHJvbUB2bXdhcmUuY29tPiB3cm90ZToKPj4gQSBjbGllbnQgY2FsbGluZyBkcm1TZXRNYXN0ZXIo KSB1c2luZyBhIGZpbGUgZGVzY3JpcHRvciB0aGF0IHdhcyBvcGVuZWQKPj4gd2hlbiBhbm90aGVy IGNsaWVudCB3YXMgbWFzdGVyIHdvdWxkIGluaGVyaXQgdGhlIGxhdHRlciBjbGllbnQncyBtYXN0 ZXIKPj4gb2JqZWN0IGFuZCBhbGwgaXQncyBhdXRoZW50aWNhdGVkIGNsaWVudHMuCj4+Cj4+IFRo aXMgaXMgdW53YW50ZWQgYmVoYXZpb3VyLCBhbmQgd2hlbiB0aGlzIGhhcHBlbnMsIGluc3RlYWQg YWxsb2NhdGUgYQo+PiBicmFuZCBuZXcgbWFzdGVyIG9iamVjdCBmb3IgdGhlIGNsaWVudCBjYWxs aW5nIGRybVNldE1hc3RlcigpLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgSGVsbHN0cm9t IDx0aGVsbHN0cm9tQHZtd2FyZS5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9k cnYuYyAgfCAxMiArKysrKysrCj4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZvcHMuYyB8IDgwICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPj4gIGluY2x1ZGUv ZHJtL2RybVAuaCAgICAgICAgIHwgIDYgKysrKwo+PiAgMyBmaWxlcyBjaGFuZ2VkLCA3MCBpbnNl cnRpb25zKCspLCAyOCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jCj4+IGluZGV4IDkzNjI2 MDkuLjFmMDcyYmEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMKPj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+PiBAQCAtMTYwLDYgKzE2MCwxOCBAQCBp bnQgZHJtX3NldG1hc3Rlcl9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRh LAo+PiAgICAgICAgICAgICAgICAgZ290byBvdXRfdW5sb2NrOwo+PiAgICAgICAgIH0KPj4KPj4g KyAgICAgICBpZiAoIWZpbGVfcHJpdi0+YWxsb3dlZF9tYXN0ZXIpIHsKPj4gKyAgICAgICAgICAg ICAgIHN0cnVjdCBkcm1fbWFzdGVyICpzYXZlZF9tYXN0ZXIgPSBmaWxlX3ByaXYtPm1hc3RlcjsK Pj4gKwo+PiArICAgICAgICAgICAgICAgcmV0ID0gZHJtX25ld19zZXRfbWFzdGVyKGRldiwgZmls ZV9wcml2KTsKPj4gKyAgICAgICAgICAgICAgIGlmIChyZXQpCj4+ICsgICAgICAgICAgICAgICAg ICAgICAgIGZpbGVfcHJpdi0+bWFzdGVyID0gc2F2ZWRfbWFzdGVyOwo+IEltaG8gdGhpcyBzaG91 bGRuJ2UgYmVsb25nIGhlcmUgYnV0IGluIGRybV9uZXdfc2V0X21hc3RlcigpIC0gaS5lLiBpdAo+ IHNob3VsZCB1bndpbmQgdGhpbmdzIG9uIGVycm9yLiBTaW1pbGFybHksIGFsdGhvdWdoIHdlIHJl c3RvcmUgdGhlIG9sZAo+IGRybV9tYXN0ZXIgKGJlbG93KSwgd2Ugc3RpbGwgaGF2ZSBpc19tYXN0 ZXIsIGFsbG93ZWRfbWFzdGVyIGFuZAo+IGF1dGhlbnRpY2F0ZWQgc2V0LiBUaHVzIG9uZSBjYW4g cmV1c2UgdGhlIGVsZXZhdGVkIGNyZWRlbnRpYWxzIChpcwo+IHRoaXMgdGhlIHJpZ2h0IHRlcm1p bm9sb2d5PykgZGVzcGl0ZSB0aGF0IHRoZSBpb2N0bCBoYXMgZmFpbGVkLgo+Cj4+ICsgICAgICAg ICAgICAgICBlbHNlCj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGRybV9tYXN0ZXJfcHV0KCZz YXZlZF9tYXN0ZXIpOwo+PiArCj4+ICsgICAgICAgICAgICAgICBnb3RvIG91dF91bmxvY2s7Cj4+ ICsgICAgICAgfQo+PiArCj4+ICAgICAgICAgZmlsZV9wcml2LT5taW5vci0+bWFzdGVyID0gZHJt X21hc3Rlcl9nZXQoZmlsZV9wcml2LT5tYXN0ZXIpOwo+PiAgICAgICAgIGZpbGVfcHJpdi0+aXNf bWFzdGVyID0gMTsKPj4gICAgICAgICBpZiAoZGV2LT5kcml2ZXItPm1hc3Rlcl9zZXQpIHsKPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm9wcy5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV9mb3BzLmMKPj4gaW5kZXggYzU5Y2U0ZC4uNGI1YzExYyAxMDA2NDQKPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9mb3BzLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mb3Bz LmMKPj4gQEAgLTEyNiw2ICsxMjYsNTYgQEAgc3RhdGljIGludCBkcm1fY3B1X3ZhbGlkKHZvaWQp Cj4+ICB9Cj4+Cj4+ICAvKioKPj4gKyAqIGRybV9uZXdfc2V0X21hc3RlciAtIEFsbG9jYXRlIGEg bmV3IG1hc3RlciBvYmplY3QgYW5kIGJlY29tZSBtYXN0ZXIgZm9yIHRoZQo+PiArICogYXNzb2Np YXRlZCBtYXN0ZXIgcmVhbG0uCj4+ICsgKgo+PiArICogQGRldjogVGhlIGFzc29jaWF0ZWQgZGV2 aWNlLgo+PiArICogQGZwcml2OiBGaWxlIHByaXZhdGUgaWRlbnRpZnlpbmcgdGhlIGNsaWVudC4K Pj4gKyAqCj4+ICsgKiBUaGlzIGZ1bmN0aW9uIG11c3QgYmUgY2FsbGVkIHdpdGggZGV2OjpzdHJ1 Y3RfbXV0ZXggaGVsZC4gUmV0dXJucyBuZWdhdGl2ZQo+PiArICogZXJyb3IgY29kZSBvbiBmYWls dXJlLCB6ZXJvIG9uIHN1Y2Nlc3MuCj4+ICsgKi8KPj4gK2ludCBkcm1fbmV3X3NldF9tYXN0ZXIo c3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9maWxlICpmcHJpdikKPj4gK3sKPj4g KyAgICAgICBpbnQgcmV0Owo+PiArCj4+ICsgICAgICAgbG9ja2RlcF9hc3NlcnRfaGVsZF9vbmNl KCZkZXYtPm1hc3Rlcl9tdXRleCk7Cj4+ICsgICAgICAgLyogY3JlYXRlIGEgbmV3IG1hc3RlciAq Lwo+PiArICAgICAgIGZwcml2LT5taW5vci0+bWFzdGVyID0gZHJtX21hc3Rlcl9jcmVhdGUoZnBy aXYtPm1pbm9yKTsKPj4gKyAgICAgICBpZiAoIWZwcml2LT5taW5vci0+bWFzdGVyKQo+PiArICAg ICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07Cj4+ICsKPj4gKyAgICAgICBmcHJpdi0+aXNfbWFz dGVyID0gMTsKPj4gKyAgICAgICBmcHJpdi0+YWxsb3dlZF9tYXN0ZXIgPSAxOwo+PiArCj4+ICsg ICAgICAgLyogdGFrZSBhbm90aGVyIHJlZmVyZW5jZSBmb3IgdGhlIGNvcHkgaW4gdGhlIGxvY2Fs IGZpbGUgcHJpdiAqLwo+PiArICAgICAgIGZwcml2LT5tYXN0ZXIgPSBkcm1fbWFzdGVyX2dldChm cHJpdi0+bWlub3ItPm1hc3Rlcik7Cj4+ICsKPj4gKyAgICAgICBmcHJpdi0+YXV0aGVudGljYXRl ZCA9IDE7Cj4+ICsKPj4gKyAgICAgICBpZiAoZGV2LT5kcml2ZXItPm1hc3Rlcl9jcmVhdGUpIHsK Pj4gKyAgICAgICAgICAgICAgIHJldCA9IGRldi0+ZHJpdmVyLT5tYXN0ZXJfY3JlYXRlKGRldiwg ZnByaXYtPm1hc3Rlcik7Cj4+ICsgICAgICAgICAgICAgICBpZiAocmV0KSB7Cj4+ICsgICAgICAg ICAgICAgICAgICAgICAgIC8qIGRyb3AgYm90aCByZWZlcmVuY2VzIGlmIHRoaXMgZmFpbHMgKi8K Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgZHJtX21hc3Rlcl9wdXQoJmZwcml2LT5taW5vci0+ bWFzdGVyKTsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgZHJtX21hc3Rlcl9wdXQoJmZwcml2 LT5tYXN0ZXIpOwo+PiArICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gcmV0Owo+PiArICAg ICAgICAgICAgICAgfQo+PiArICAgICAgIH0KPj4gKyAgICAgICBpZiAoZGV2LT5kcml2ZXItPm1h c3Rlcl9zZXQpIHsKPj4gKyAgICAgICAgICAgICAgIHJldCA9IGRldi0+ZHJpdmVyLT5tYXN0ZXJf c2V0KGRldiwgZnByaXYsIHRydWUpOwo+PiArICAgICAgICAgICAgICAgaWYgKHJldCkgewo+IEFm YWljcyBib3RoIG9mIHRoZXNlIGNhbGxiYWNrcyBhcmUgYXZhaWxhYmxlIGZyb20gbGVnYWN5KFVN UykgZHJpdmVycwo+IGFyZW4ndCB0aGV5ID8gV2l0aCB0aGUgcmFkZW9uIFVNUyByZW1vdmFsIHBh dGNoZXMgaW4gdGhlIHdvcmtzLCB0aGlzCj4gbGVhdmVzIHZtd2dmeC4KPgo+IEVpdGhlciB3YXks IHBlcmhhcHMgd2Ugc2hvdWxkIHNldCBpc19tYXN0ZXIsIGFsbG93ZWRfbWFzdGVyIGFuZAo+IGF1 dGhlbnRpY2F0ZWQgYWZ0ZXIgdGhlc2UgdHdvID8gT3IgYWx0ZXJuYXRpdmVseSByZXN0b3JlIHRo ZSBvcmlnaW5hbAo+IHZhbHVlcyBvbiBlcnJvci4KPgo+IERpZCBJIG1pc3Mgc29tZXRoaW5nIG9y IHRoZSBhYm92ZSBzb3VuZHMgYWJvdXQgcmlnaHQgPwpJdCBkb2VzLiBJJ2xsIGFkZHJlc3MgdGhp cyBhbmQgcmVzZW5kLgoKVGhhbmtzIGZvciByZXZpZXdpbmchCgovVGhvbWFzCgoKCj4KPiBSZWdh cmRzLAo+IEVtaWwKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK