From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Date: Tue, 1 Dec 2015 17:37:44 -0600 Subject: [U-Boot] [RFC] arm: socfpga: introduce SOCFPGA_GEN5 or SOCFPGA_GEN10 In-Reply-To: <201512020031.59528.marex@denx.de> References: <1449007202-5980-1-git-send-email-dinguyen@opensource.altera.com> <201512020031.59528.marex@denx.de> Message-ID: <565E2F48.9090507@opensource.altera.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/01/2015 05:31 PM, Marek Vasut wrote: > On Tuesday, December 01, 2015 at 11:00:02 PM, dinguyen at opensource.altera.com > wrote: >> From: Dinh Nguyen >> >> Define SOCFPGA_GEN5 which applies to Arria5/Cyclone5 hardware, and >> SOCFPGA_GEN10 for Arria10 hardware. >> >> This would allow us to use the shorten define in the rest of code. >> >> Signed-off-by: Dinh Nguyen >> --- >> include/configs/socfpga_common.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/configs/socfpga_common.h >> b/include/configs/socfpga_common.h index 3374683..8fc5666 100644 >> --- a/include/configs/socfpga_common.h >> +++ b/include/configs/socfpga_common.h >> @@ -6,6 +6,11 @@ >> #ifndef __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__ >> #define __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__ >> >> +#if defined(CONFIG_TARGET_SOCFPGA_ARRIA5) || >> defined(CONFIG_TARGET_SOCFPGA_CYCLONE5) +#define SOCFPGA_GEN5 >> +#elif defined(CONFIG_TARGET_SOCFPGA_ARRIA10) >> +#define SOCFPGA_GEN10 >> +#endif > > The same thing can be done in arch/arm/mach-socfpga/Kconfig -- introduce > blank symbol similar to TARGET_SOCFPGA_CYCLONE5 and make both of the > TARGET_SOCFPGA_CYCLONE5 and TARGET_SOCFPGA_ARRIA5 select it. But do you > think it's worth it ? > Yes, I like that idea! Thanks, Dinh