Re: Asterisk deadlocks since Kernel 4.1

From: Philipp Hahn <pmhahn@pmhahn.de>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>,
	Stefan Priebe - Profihost AG <s.priebe@profihost.ag>,
	Florian Weimer <fweimer@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: Asterisk deadlocks since Kernel 4.1
Date: Wed, 02 Dec 2015 18:51:52 +0100	[thread overview]
Message-ID: <565F2FB8.9010006@pmhahn.de> (raw)
In-Reply-To: <8737vlt6xb.fsf@stressinduktion.org>

Hi,

Am 02.12.2015 um 12:40 schrieb Hannes Frederic Sowa:
> Cool, thanks a lot. Does this patch make a difference?
> 
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 59651af..278e94c 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -1137,7 +1137,7 @@ static int netlink_insert(struct sock *sk, u32 portid)
>  
>  	/* We need to ensure that the socket is hashed and visible. */
>  	smp_wmb();
> -	nlk_sk(sk)->bound = portid;
> +	nlk_sk(sk)->bound = true;
>  
>  err:
>  	release_sock(sk);

Will test that tomorrow.

What confuss me is that it works with 4.3. I compared
net/netlink/af_netlink.[ch] for differences between v4.1.10 and v4.3 and
didn't find anything which would explain only 4,1 getting stuck.

Philipp