All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@RedHat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: libtirpc List <libtirpc-devel@lists.sourceforge.net>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] Restore creating listening connection to server connections
Date: Wed, 11 Apr 2018 09:39:37 -0400	[thread overview]
Message-ID: <565f3f27-4435-3bf4-3ebe-29f87cae9c8f@RedHat.com> (raw)
In-Reply-To: <AEE2F42D-04C5-45AA-BC4B-773ED41B238E@oracle.com>

Hey,

On 04/10/2018 06:29 PM, Chuck Lever wrote:
> 
> 
>> On Apr 10, 2018, at 3:30 PM, Steve Dickson <steved@redhat.com> wrote:
>>
>> Commit 46e04a73 changed svc_com_create() to avoid using
>> reserve ports but removed the listen() call which
>> could break, undocumented expectations, of legacy
>> server apps.
>>
>> Reserve ports are not needed for listening ports, so
>> the new  __binddynport() is used to avoid squatting
>> on ports that are assigned to other network services,
>> but it is important to say backwards compatible
>> with the legacy glibc code so the the listen()
>> call is added back.
> 
> svc_tli_create should already perform a call to __binddynport()
> and to listen(2). That's why those calls were removed from
> svc_com_create().
> 
Fair enough... I did miss that call to svc_tli_create().

It appears the callers of svc_com_create() are no longer used
at least in nfs-utils. It appears to be the old SUN RPC API
and we using the TIRPC API.

steved.

  reply	other threads:[~2018-04-11 13:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 21:30 [PATCH 1/2] Restore using reserve ports for client connections Steve Dickson
2018-04-10 21:30 ` [PATCH 2/2] Restore creating listening connection to server connections Steve Dickson
2018-04-10 22:29   ` Chuck Lever
2018-04-11 13:39     ` Steve Dickson [this message]
2018-04-10 22:17 ` [Libtirpc-devel] [PATCH 1/2] Restore using reserve ports for client connections Chuck Lever
2018-04-11 12:34   ` Steve Dickson
2018-04-11 12:59     ` Thorsten Kukuk
2018-04-11 14:07       ` Steve Dickson
2018-04-11 14:09         ` Chuck Lever
2018-04-11 14:09     ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565f3f27-4435-3bf4-3ebe-29f87cae9c8f@RedHat.com \
    --to=steved@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=libtirpc-devel@lists.sourceforge.net \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.