From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCHv6] 04/28] build: convert HAS_PASSTHROUGH use to Kconfig Date: Thu, 03 Dec 2015 01:58:58 -0700 Message-ID: <5660126202000078000BB933@prv-mh.provo.novell.com> References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com> <1448387538-12208-5-git-send-email-cardoe@cardoe.com> <565C704D02000078000BA449@prv-mh.provo.novell.com> <565F8EAA.2050508@cardoe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <565F8EAA.2050508@cardoe.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Doug Goldstein Cc: Keir Fraser , Ian Campbell , Andrew Cooper , xen-devel@lists.xen.org, Stefano Stabellini , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org >>> On 03.12.15 at 01:36, wrote: > On 11/30/15 8:50 AM, Jan Beulich wrote: >>>>> On 24.11.15 at 18:51, wrote: >>> @@ -348,9 +348,9 @@ static XSM_INLINE int xsm_deassign_device(XSM_DEFAULT_ARG struct domain *d, uint >>> return xsm_default_action(action, current->domain, d); >>> } >>> >>> -#endif /* HAS_PASSTHROUGH && HAS_PCI */ >>> +#endif /* CONFIG_HAS_PASSTHROUGH && HAS_PCI */ >> >> I don't think fiddling with trailing comments like this one is really >> useful - the connection is clear also without CONFIG_ prefix. > > Most of this series was mechanical early on (e.g. sed). I can > selectively undo updating the comments if that's desirable. While I agree this makes it more work for you, it would certainly ease review (simply by shrinking the amount of changes to look at). Jan