From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4X1G-0005dF-DR for qemu-devel@nongnu.org; Thu, 03 Dec 2015 11:46:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4X1C-0001Et-23 for qemu-devel@nongnu.org; Thu, 03 Dec 2015 11:46:10 -0500 References: <1449160660-3777-1-git-send-email-armbru@redhat.com> <1449160660-3777-2-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <566071C4.30706@redhat.com> Date: Thu, 3 Dec 2015 09:45:56 -0700 MIME-Version: 1.0 In-Reply-To: <1449160660-3777-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qcrvHqQT3sEXuPh69bxBPf583NHoa8c6H" Subject: Re: [Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de, david@gibson.dropbear.id.au This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qcrvHqQT3sEXuPh69bxBPf583NHoa8c6H Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/03/2015 09:37 AM, Markus Armbruster wrote: > Since prop_get_fdt() is only used with QmpOutputVisitor, errors > shouldn't actually happen, so this is only a latent bug. >=20 > Signed-off-by: Markus Armbruster > --- > hw/ppc/spapr_drc.c | 32 ++++++++++++++++++++++++++------ > 1 file changed, 26 insertions(+), 6 deletions(-) I posted a similar patch, but using &error_abort rather than propagating, here: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg05788.html But I like yours better. >=20 > diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c > index f34bc04..4e7a1d3 100644 > --- a/hw/ppc/spapr_drc.c > +++ b/hw/ppc/spapr_drc.c Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qcrvHqQT3sEXuPh69bxBPf583NHoa8c6H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWYHHEAAoJEKeha0olJ0NqT20H/j6lvSa4n6HCg2wHWYcGPnw+ boO8R5qzTCDUx97ehEH4afS3q3Ao/1YcEP+qPRzEWfTXtChoGXp1KZz+o+HSXyGa HID1VHHIiWsTFaGKmtykTQR5GpOKNOate1XerOQOeWp4X+sVSsYVvDk/stRQ+WCx 1QGyIJZi5skeZiPDr1Q29Jdo9Y+7v0d7N91TIdgWCXlG+u1Y4LEfDRBqlzc/2Apg NGBC6fnGqgJAGzZYRkVW1xQHXbIEqjG1YpTa5pk8T24TgwseussAD3T287pMKCQG jyPmpOlBe1ooEU1nO/FZ47l5dxF77vs5ErDEPNH/rIglkoh1RF39SDNG5UyZaZQ= =qRzc -----END PGP SIGNATURE----- --qcrvHqQT3sEXuPh69bxBPf583NHoa8c6H--