From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4XAJ-0004Aq-22 for qemu-devel@nongnu.org; Thu, 03 Dec 2015 11:55:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4XAE-0004si-4l for qemu-devel@nongnu.org; Thu, 03 Dec 2015 11:55:30 -0500 References: <1449160660-3777-1-git-send-email-armbru@redhat.com> <1449160660-3777-4-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <566073FC.5030303@redhat.com> Date: Thu, 3 Dec 2015 09:55:24 -0700 MIME-Version: 1.0 In-Reply-To: <1449160660-3777-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b8XWIQKlDPoaCDjsLP3UAho6P0JsJkVuw" Subject: Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de, david@gibson.dropbear.id.au This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --b8XWIQKlDPoaCDjsLP3UAho6P0JsJkVuw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/03/2015 09:37 AM, Markus Armbruster wrote: > It should only be created via spapr_dr_connector_new(). Attempting to > create it with -device crashes. >=20 > Signed-off-by: Markus Armbruster > --- > hw/ppc/spapr_drc.c | 4 ++++ > 1 file changed, 4 insertions(+) For 2.5, this is an appropriate last-minute crash-avoider. The FIXME reminds us to do better in 2.6. Reviewed-by: Eric Blake >=20 > diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c > index dad157f..8be62c3 100644 > --- a/hw/ppc/spapr_drc.c > +++ b/hw/ppc/spapr_drc.c > @@ -599,6 +599,10 @@ static void spapr_dr_connector_class_init(ObjectCl= ass *k, void *data) > drck->attach =3D attach; > drck->detach =3D detach; > drck->release_pending =3D release_pending; > + /* > + * Reason: it crashes FIXME find and document the real reason > + */ > + dk->cannot_instantiate_with_device_add_yet =3D true; > } > =20 > static const TypeInfo spapr_dr_connector_info =3D { >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --b8XWIQKlDPoaCDjsLP3UAho6P0JsJkVuw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWYHP8AAoJEKeha0olJ0Nq0eQH/0eqfPUoR1PDxmN8c0F0AmfK uD3l4trH08nWlyMMslbP0f47n/T6MvuqByvMRt+zMkw39j2tNsUchRRDQl7ab5CN LrhPR1LHSY3ty675luWs/fs2UG5lwMjUadM4jusmoijbW+erSP12yaFkvL2KjITL 6JBEmUlt7PqL+7Ii8PDDiQRF3N6LXBF1HaX/L+DEV47+kj4nXkQUGHjdKc0DDMR8 eH3/JKGrZAb5V/nlHBd2Ik+SlVjnJaHGQ5rXs1/S+7x0S8VVvq5iWF04ku7x8bbn G/fvdCMxB+HUT7kH9gvcHuGvm3FQ6nyye3EqYtBxj5Uht0YbHAVoNpuKSfD/IoY= =2ESa -----END PGP SIGNATURE----- --b8XWIQKlDPoaCDjsLP3UAho6P0JsJkVuw--