From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Fri, 4 Dec 2015 13:08:37 -0700 Subject: [U-Boot] [PATCH 1/4] tegra: Remove merge markers in some Kconfig files In-Reply-To: References: <1449244720-19253-1-git-send-email-sjg@chromium.org> <5661CA72.20307@wwwdotorg.org> Message-ID: <5661F2C5.7020403@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/04/2015 10:25 AM, Simon Glass wrote: > Hi Stephen, > > On 4 December 2015 at 10:16, Stephen Warren wrote: >> On 12/04/2015 08:58 AM, Simon Glass wrote: >>> >>> These were added by mistake in commit fde7e189. They cause a warning when >>> configuring the boards. Remove them. >> >> >> Patches 1-3, >> Tested-by: Stephen Warren >> >> It would be useful to include the appropriate Fixes: tags in the commit >> message, and this issue was originally: >> >> Reported-by: Kevin Hilman > > Thanks - what Fixes tags? I'd expect the following at the start of the "signature paragraph": Fixes: fde7e18938d8 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig") Referencing in a standard way the commits that caused the bug that this patch fixes makes researching bug/commit history easier. Admittedly that tag is something from the Linux kernel development process and isn't mandated by U-Boot's process, but I think it's a good idea that's worth following.