From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Yonghong Song <yhs@fb.com>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: linux-sparse@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, clang-built-linux@googlegroups.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 2/2] compiler.h: Include asm/rwonce.h under ARM64 and ALPHA to fix build errors
Date: Mon, 18 Jan 2021 17:25:35 +0800 [thread overview]
Message-ID: <5663510d-2aa5-c1f2-d0c8-5313cc2a4a18@loongson.cn> (raw)
In-Reply-To: <33050fcc-a4a0-af2e-6fba-dca248f5f23b@fb.com>
On 01/14/2021 01:14 AM, Yonghong Song wrote:
> I do not think this fix is correct. x86 does not define its own
> rwonce.h and still compiles fine.
>
> As noted in the above, we have include/asm-generic/rwonce.h.
> Once you do a proper build, you will have rwonce.h in arch
> generated directory like
>
> -bash-4.4$ find . -name rwonce.h
> ./include/asm-generic/rwonce.h
> ./arch/alpha/include/asm/rwonce.h
> ./arch/arm64/include/asm/rwonce.h
> ./arch/x86/include/generated/asm/rwonce.h
>
> for mips, it should generated in
> arch/mips/include/generated/asm/rwonce.h. Please double check why this
> does not happen.
Hi Yonghong,
Thank you very much for your reply.
You are right, this patch is meaningless.
I find this build error when make M=samples/bpf after make clean,
so the ./arch/mips/include/generated/asm/rwonce.h is not exist.
After rebuild the kernel, this header file can be found when make
M=samples/bpf due to samples/bpf/Makefile contains $LINUXINCLUDE.
$ find . -name rwonce.h
./include/asm-generic/rwonce.h
./arch/arm64/include/asm/rwonce.h
./arch/mips/include/generated/asm/rwonce.h
./arch/alpha/include/asm/rwonce.h
$ cat ./arch/mips/include/generated/asm/rwonce.h
#include <asm-generic/rwonce.h>
Hi Sergei and kernel test robot,
Thank you for your suggestion and report,
please ignore this patch, sorry for the noise.
Thanks,
Tiezhu
next prev parent reply other threads:[~2021-01-18 9:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 10:57 [PATCH 0/2] Fix build errors and warnings when make M=samples/bpf Tiezhu Yang
2021-01-13 10:57 ` [PATCH bpf 1/2] samples/bpf: Set flag __SANE_USERSPACE_TYPES__ for MIPS to fix build warnings Tiezhu Yang
2021-01-13 17:12 ` Yonghong Song
2021-01-18 3:22 ` Tiezhu Yang
2021-01-18 18:44 ` Yonghong Song
2021-01-13 10:57 ` [PATCH 2/2] compiler.h: Include asm/rwonce.h under ARM64 and ALPHA to fix build errors Tiezhu Yang
2021-01-13 17:14 ` Yonghong Song
2021-01-18 9:25 ` Tiezhu Yang [this message]
2021-01-14 2:18 ` kernel test robot
2021-01-14 8:40 ` Sergei Shtylyov
2021-01-14 15:58 ` kernel test robot
2021-01-13 17:16 ` [PATCH 0/2] Fix build errors and warnings when make M=samples/bpf Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5663510d-2aa5-c1f2-d0c8-5313cc2a4a18@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=lkp@intel.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.