From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v7 45/50] drivers/of: Avoid recursively calling unflatten_dt_node() Date: Sun, 6 Dec 2015 19:40:56 -0800 Message-ID: <5664FFC8.2060904@roeck-us.net> References: <1446642770-4681-1-git-send-email-gwshan@linux.vnet.ibm.com> <1446642770-4681-46-git-send-email-gwshan@linux.vnet.ibm.com> <1449446087.21036.1.camel@kernel.crashing.org> <5664ED0C.6060706@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Rob Herring Cc: Benjamin Herrenschmidt , Gavin Shan , linuxppc-dev , "linux-pci@vger.kernel.org" , "devicetree@vger.kernel.org" , Michael Ellerman , aik@ozlabs.ru, Bjorn Helgaas , Grant Likely , Pantelis Antoniou , Frank Rowand List-Id: devicetree@vger.kernel.org On 12/06/2015 06:33 PM, Rob Herring wrote: > On Sun, Dec 6, 2015 at 8:21 PM, Guenter Roeck wrote: >> On 12/06/2015 03:54 PM, Benjamin Herrenschmidt wrote: >>> >>> On Sun, 2015-12-06 at 14:28 -0600, Rob Herring wrote: >>>> >>>> >>>> Do you plan to respin the OF parts at least soon? There's another >>>> problem Guenter found that of_fdt_unflatten_tree is not re-entrant due >>>> to "depth" being static and this series fixes that. So I'd rather >>>> apply this and avoid adding a mutex if possible. >>> >>> >>> Gavin is on vacation until next year. >>> >> >> That is a bit more than the timeline I am looking for. >> >> Rob, any chance to accept my patch for now ? After all, it can be >> reverted after the rework is complete, and it would be easier >> to apply to earlier kernels. > > Yes, will do. It's only 4.1 and later that it should be marked for stable? > Yes, I think so. Earlier kernels would need a manual backport. Thanks, Guenter