All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: netdev <netdev@vger.kernel.org>, edumazet@google.com
Subject: net: tso: add UDP segmentation support: adds regression for ax200 upload
Date: Wed, 16 Dec 2020 15:09:22 -0800	[thread overview]
Message-ID: <5664fa0f-aef2-c336-651a-093c9eed23ab@candelatech.com> (raw)

Hello Eric,

The patch below evidently causes TCP throughput to be about 50Mbps instead of 700Mbps
when using ax200 to upload tcp traffic.

When I disable TSO, performance goes back up to around 700Mbps.

I recall ~5 years ago we had similar TCP related performance issues with ath10k.
I vaguely recall that there might be some driver-level socket pacing tuning value, but I cannot
find the right thing to search for.  Is this really a thing?  If so, maybe it will
be a way to resolve this issue?

See this more thorough bug report:

https://bugzilla.kernel.org/show_bug.cgi?id=209913

Patch description:
net: tso: add UDP segmentation support
Note that like TCP, we do not support additional encapsulations,
and that checksums must be offloaded to the NIC.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

             reply	other threads:[~2020-12-16 23:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 23:09 Ben Greear [this message]
2020-12-16 23:59 ` net: tso: add UDP segmentation support: adds regression for ax200 upload Ben Greear
2020-12-17 10:11   ` Eric Dumazet
2020-12-17 17:56     ` Ben Greear
2020-12-17 18:07       ` Eric Dumazet
2020-12-17 18:13         ` Ben Greear
2020-12-17 18:20           ` Eric Dumazet
2020-12-17 20:40             ` Ben Greear
2020-12-18 20:16               ` Jakub Kicinski
2020-12-19 15:18                 ` Johannes Berg
2020-12-19 16:55                   ` Ben Greear
2020-12-21 18:46                     ` Eric Dumazet
2020-12-21 18:54                       ` Jakub Kicinski
2020-12-21 19:04                       ` Eric Dumazet
2020-12-21 19:14                         ` Eric Dumazet
2020-12-21 20:01                           ` Rainer Suhm
2020-12-24 17:48                             ` Ben Greear
2021-01-19  8:53                           ` Johannes Berg
2021-01-19 10:02                             ` Eric Dumazet
2021-01-25 14:57                               ` Johannes Berg
2021-01-25 14:58                                 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5664fa0f-aef2-c336-651a-093c9eed23ab@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.