From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5w3e-0003fN-CS for qemu-devel@nongnu.org; Mon, 07 Dec 2015 08:42:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5w3b-0000CX-6e for qemu-devel@nongnu.org; Mon, 07 Dec 2015 08:42:26 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:37391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5w3b-0000CE-0C for qemu-devel@nongnu.org; Mon, 07 Dec 2015 08:42:23 -0500 References: <1449475725-16453-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Marcel Apfelbaum Message-ID: <56658CBB.10009@gmail.com> Date: Mon, 7 Dec 2015 15:42:19 +0200 MIME-Version: 1.0 In-Reply-To: <1449475725-16453-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Preparation for PCI devices convert to realize() Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: jiri@resnulli.us, mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, sfeldma@gmail.com, hare@suse.de, dmitry@daynix.com, pbonzini@redhat.com, jsnow@redhat.com, emu-block@nongnu.org, kraxel@redhat.com On 12/07/2015 10:08 AM, Cao jin wrote: > There are many PCI devices still using .init() as its initialization function, > I am planning to do the "convert to realize()" work, and PCI bridge devices are > chosen first. The supporting functions should be modified first.msi_init() & > msix_init() are supporting functions for PCI devices. > > Because this patchset is much different from the previous one, so, didn`t > add "V2" in the subject Hi, Even if the patches are different is worth mentioning V2, otherwise the maintainer would not know which to take. Thanks, Marcel > > Cao jin (2): > Add param Error** to msi_init() & modify the callers > Add param Error** to msix_init() & modify the callers > > hw/audio/intel-hda.c | 7 ++++++- > hw/ide/ich.c | 2 +- > hw/net/rocker/rocker.c | 3 ++- > hw/net/vmxnet3.c | 7 +++++-- > hw/pci-bridge/ioh3420.c | 6 +++++- > hw/pci-bridge/pci_bridge_dev.c | 6 +++++- > hw/pci-bridge/xio3130_downstream.c | 7 ++++++- > hw/pci-bridge/xio3130_upstream.c | 7 ++++++- > hw/pci/msi.c | 17 +++++++++++++---- > hw/pci/msix.c | 13 ++++++++++--- > hw/scsi/megasas.c | 28 +++++++++++++++++++++------- > hw/scsi/vmw_pvscsi.c | 3 ++- > hw/usb/hcd-xhci.c | 7 +++++-- > hw/vfio/pci.c | 7 +++++-- > include/hw/pci/msi.h | 4 ++-- > include/hw/pci/msix.h | 3 ++- > 16 files changed, 96 insertions(+), 31 deletions(-) >