All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: John David Anglin <dave.anglin@bell.net>, linux-parisc@vger.kernel.org
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH 1/3] parisc: Disable huge pages on Mako machines
Date: Mon, 7 Dec 2015 22:19:10 +0100	[thread overview]
Message-ID: <5665F7CE.3010209@gmx.de> (raw)
In-Reply-To: <5665A221.5050309@bell.net>

Hi Dave,

On 07.12.2015 16:13, John David Anglin wrote:
> On 2015-12-06 3:43 PM, Helge Deller wrote:
>> Mako-based machines (PA8800 and PA8900 CPUs) don't allow aliasing on
>> non-equaivalent addresses.

> Where do the non equivalent addresses come from?

I think the main problem is the gateway page.
It's mapped at address 0 into userspace, but needs to jump into kernel space too.
This somehow breaks the huge page mapping.

> When non equivalent mappings are
> used in the kernel, we try pretty hard to ensure that the user mappings are flushed prior
> to using the kernel mapping and then we flush the kernel mapping. There's also the
> copy_user_page_asm and clear_user_page_asm routines that do copies and clear operations
> using equivalent addresses.  I have some notes on the flushing needed using these routines.

Yes.

> One source of non equivalent addresses is the boundary between text and data in user
> applications.  At one time, we had data immediately after the text and non equivalent
> addresses.  Now, the start of data is rounded up so it starts on a 4K page boundary.
> This may need adjustment for huge pages, but that implies a rebuild of user space.

No, userspace is not mapped in huge pages (but it could if someone gets libhugetlbfs working).
Right now, only hugepages would only be used for mmap() or shmget() memory if the flags
are given. 

> I tend to think flush_tlb_all() doesn't work because the aliasing rules are being broken.
> Disabling it causes a significant increase in time to flush the tlb.

Yes.
Right now the patches I sent don't seem to work as I expected them to do.
So, it's not what I currently tend to commit. I'm still working on it, but my time
is very limited, so it will need some time.
My current top goal is to push patches for kernel v4.4 which fixes the boot crash on Mako machines.

Helge

  reply	other threads:[~2015-12-07 21:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 20:43 [PATCH 1/3] parisc: Disable huge pages on Mako machines Helge Deller
2015-12-06 20:43 ` [PATCH 2/3] parisc: Disable tlb flush optimization with huge pages Helge Deller
2015-12-06 20:43 ` [PATCH 3/3] parisc: protect huge pte changes with spinlocks Helge Deller
2015-12-07 15:13 ` [PATCH 1/3] parisc: Disable huge pages on Mako machines John David Anglin
2015-12-07 21:19   ` Helge Deller [this message]
2015-12-08  2:03     ` John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665F7CE.3010209@gmx.de \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dave.anglin@bell.net \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.