All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hongzhi, Song <hongzhi.song@windriver.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] kernel/syscall/setrlimit05.c: use a legal bad address for mips
Date: Tue, 6 Nov 2018 14:36:58 +0800	[thread overview]
Message-ID: <5665e310-b1f1-60e5-6aa7-289eba6cf6a9@windriver.com> (raw)
In-Reply-To: <20181105152237.GA3478@rei>



On 11/05/2018 11:22 PM, Cyril Hrubis wrote:
> Hi!
>> diff --git a/testcases/kernel/syscalls/setrlimit/setrlimit05.c b/testcases/kernel/syscalls/setrlimit/setrlimit05.c
>> index e716722..57b0b82 100644
>> --- a/testcases/kernel/syscalls/setrlimit/setrlimit05.c
>> +++ b/testcases/kernel/syscalls/setrlimit/setrlimit05.c
>> @@ -31,9 +31,13 @@ static void verify_setrlimit(void)
>>   	int status;
>>   	pid_t pid;
>>   
>> +    void *bad_addr;
>> +
>> +    bad_addr = tst_get_bad_addr(NULL);
> It would be better if we called this only once in the test setup()
> function as the function actually maps a page of memory, the test may
> fail if we pass large enough -i parameter.

This case just runs one time. But I still send V2 with using setup() to 
apply memory.

--Hongzhi

>
>>   	pid = SAFE_FORK();
>>   	if (!pid) {
>> -		TEST(setrlimit(RLIMIT_NOFILE, (void *) -1));
>> +		TEST(setrlimit(RLIMIT_NOFILE,(struct rlimit *)bad_addr));
>>   		if (TST_RET != -1) {
>>   			tst_res(TFAIL, "setrlimit()  succeeded unexpectedly");
>>   			exit(0);
>> -- 
>> 2.8.1
>>
>>
>> -- 
>> Mailing list info: https://lists.linux.it/listinfo/ltp


  reply	other threads:[~2018-11-06  6:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05  7:30 [LTP] [PATCH] kernel/syscall/setrlimit05.c: use a legal bad address for mips Hongzhi.Song
2018-11-05  7:51 ` Xiao Yang
2018-11-06  7:07   ` Hongzhi, Song
2018-11-05 15:22 ` Cyril Hrubis
2018-11-06  6:36   ` Hongzhi, Song [this message]
2018-11-06 16:05     ` Cyril Hrubis
2018-11-06  2:01 ` Xiao Yang
2018-11-06  6:48   ` Hongzhi, Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665e310-b1f1-60e5-6aa7-289eba6cf6a9@windriver.com \
    --to=hongzhi.song@windriver.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.