From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a641s-0007KO-38 for qemu-devel@nongnu.org; Mon, 07 Dec 2015 17:13:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a641o-0003ED-Qg for qemu-devel@nongnu.org; Mon, 07 Dec 2015 17:13:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a641o-0003E9-Lu for qemu-devel@nongnu.org; Mon, 07 Dec 2015 17:13:04 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 116408EA38 for ; Mon, 7 Dec 2015 22:13:04 +0000 (UTC) References: <1449467796-15856-1-git-send-email-peterx@redhat.com> From: Eric Blake Message-ID: <5666046E.6050204@redhat.com> Date: Mon, 7 Dec 2015 15:13:02 -0700 MIME-Version: 1.0 In-Reply-To: <1449467796-15856-1-git-send-email-peterx@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nKdHgSbkRsDoJaqo0v0sWc4S7ejRIfaF4" Subject: Re: [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-guest-memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: drjones@redhat.com, famz@redhat.com, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nKdHgSbkRsDoJaqo0v0sWc4S7ejRIfaF4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/06/2015 10:56 PM, Peter Xu wrote: > v5 changes: > - patch 1 > - comment English fix [Fam] > - patch 2 > - pass has_detach=3Dtrue always in hmp_dump_guest_memory [Paolo] > - patch 3 > - always use local_err and error_propagate() when need to check > the result [Fam] > - patch 8 > - add "DumpQueryResult" in DUMP_COMPLETED event [Eric] > (since DumpQueryResult is introduced in patch 10, so doing it in > patch 10 for convenience. Please let me know if I should not do > this, e.g., if patch re-ordering is required) All patches should build in isolation. It looks like you met that goal (you introduce 'DUMP_COMPLETED' event in 8 without a 'result' member, then modify it in 10), so that it at least builds. But it results in churn, in that you have multiple different definitions of 'DUMP_COMPLETED' over the life of the series. It's not a requirement to rework things since each step builds, but if I were writing the series, I do find it conceptually easier to supply patches in an order that minimizes churn (the first patch that introduces a type uses its final form, rather than going through several iterations of that type). So on that grounds, introducing DumpQueryResult as a separate patch, before either DUMP_COMPLETED or query-dump, might be easier to review, if there is a reason for a v6 spin= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nKdHgSbkRsDoJaqo0v0sWc4S7ejRIfaF4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWZgRuAAoJEKeha0olJ0NqP34H/jeaWdkbXfE/aJ70JU5I7Vby KvfoPnx6EcuhMra3RtTKiBZZ7IaMwyr0e8ZA0UCWLeMO0yAxmFsxB9UJnRZ4AECA AsKHj4/otCM4ccbtmpKuxhgRjbhsJGctBAeSTfLa3qwC6ZmTRUT/Py+hCjZcSC3R tluxMU4GsR8n0IJPBqbkzPsn6yPhB2rccAq2hUdwBb0tr0b77bm6KfTYgwkWIFzV Nl336qTZ8qoqEruyH6T/G2vo8vrmHEUTC/tAlhKletBahmGWl34Pl2diwzlW6uFk ANGIsrkfpx4vfqTgBwV7R34cbuNsSlUxQYyBSBo/Ae/qnCMdPCUL+6Q9LBU6N7U= =7UhE -----END PGP SIGNATURE----- --nKdHgSbkRsDoJaqo0v0sWc4S7ejRIfaF4--