From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a65ds-0006W6-15 for qemu-devel@nongnu.org; Mon, 07 Dec 2015 18:56:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a65dq-000334-SF for qemu-devel@nongnu.org; Mon, 07 Dec 2015 18:56:27 -0500 References: <1449531275-30362-1-git-send-email-jsnow@redhat.com> <1449531275-30362-5-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <56661C9D.8020800@redhat.com> Date: Mon, 7 Dec 2015 16:56:13 -0700 MIME-Version: 1.0 In-Reply-To: <1449531275-30362-5-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LDvPuc1iFbKpnlP4HGETDaA2NUQQ363fJ" Subject: Re: [Qemu-devel] [PATCH for-2.6 v2 04/10] fdc: add default drive type option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LDvPuc1iFbKpnlP4HGETDaA2NUQQ363fJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/07/2015 04:34 PM, John Snow wrote: > This patch adds a new explicit Floppy Drive Type option. The existing > behavior in QEMU is to automatically guess a drive type based on the > media inserted, or if a diskette is not present, arbitrarily assign one= =2E >=20 > This behavior can be described as "auto." This patch adds explicit > behaviors: 120, 144, 288, auto, and none. The new "auto" behavior > is intended to mimick current behavior, while the other types pick s/mimick/mimic/ (one of those weird 'ic' verbs where the 'k' is necessary in past tense but not present tense) > one explicitly. >=20 > In a future patch, the goal is to change the FDC's default drive type > from auto (falling back to 1.44MB) to auto (falling back to 2.88MB). >=20 > In order to allow users to obtain the old behaviors, though, a mechanis= m > for specifying the exact type of drive we want is needed. >=20 > This patch adds the properties, but it is not acted on yet in favor of > making those changes a little more explicitly clear in standalone patch= es > later in this patch set. >=20 > Signed-off-by: John Snow > --- > +++ b/qapi/block.json > @@ -40,6 +40,22 @@ > 'data': ['auto', 'none', 'lba', 'large', 'rechs']} > =20 > ## > +# @FloppyDriveType > +# > +# Type of Floppy drive to be emulated by the Floppy Disk Controller. > +# > +# @144: 1.44MB 3.5" drive > +# @288: 2.88MB 3.5" drive > +# @120: 1.5MB 5.25" drive Names start with a digit - not the prettiest, but also not the first instance, so qapi handles it just fine. And I don't have any suggestions for a better yet still concise name. > +# @none: No drive connected > +# @auto: Automatically determined by inserted media at boot > +# > +# Since: 2.6 > +## > +{ 'enum': 'FloppyDriveType', > + 'data': ['144', '288', '120', 'none', 'auto']} Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LDvPuc1iFbKpnlP4HGETDaA2NUQQ363fJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWZhydAAoJEKeha0olJ0NqW20IAJrc4WFHUShau/pZF3lfrzlG /szqPQzBAh81+c0NtVZBSiR7r9gLeorYZaCgivYY3QHKPAKOTVb6iO6Xk0A6AcdU tNyq+HYnRdZEwsF2DurOMohib7mJeZsLmVqt0FotaJx98PttEEKsrcoQVF227Qa4 2Y/tbRu/Bho7jBJ2HGPSe41RQ1mMPG3QlffDKoV/Zl9wff9FCJ/nVWDMwPsRoIcP IvGFhZ+ZTzMIb1/WT1HsIvP+14rl68+jHrnzOu1XEFTIi25Ht9+kUDqcM7JgU1eZ EwuuaBZSMkqgQCBCWjl+L5j2yg+X2+sa6tx/W/s+62nnTmmgt8KlawwMilLNm6E= =41Fb -----END PGP SIGNATURE----- --LDvPuc1iFbKpnlP4HGETDaA2NUQQ363fJ--