From mboxrd@z Thu Jan  1 00:00:00 1970
From: Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCHv6] 03/28] build: use generated Kconfig
	options for Xen
Date: Tue, 8 Dec 2015 13:53:56 -0600
Message-ID: <56673554.7050309@cardoe.com>
References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com>
	<1448387538-12208-4-git-send-email-cardoe@cardoe.com>
	<565C6F2402000078000BA43E@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6776431496915422923=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <565C6F2402000078000BA43E@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============6776431496915422923==
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="8D6lsvG9FX2D3vg9TaenRctMUxuraDDC7"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--8D6lsvG9FX2D3vg9TaenRctMUxuraDDC7
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 11/30/15 8:45 AM, Jan Beulich wrote:
>>>> On 24.11.15 at 18:51, <cardoe@cardoe.com> wrote:
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -26,6 +26,9 @@ default: build
>>  .PHONY: dist
>>  dist: install
>> =20
>> +.PHONY: build
>> +build:: $(BASEDIR)/include/config/auto.conf
>> +
>>  .PHONY: build install uninstall clean distclean cscope TAGS tags MAP =
gtags
>=20
> I do not see why you need to add build to PHONY's dependencies
> another time.
>=20
>> @@ -227,9 +230,14 @@ kconfig :=3D silentoldconfig oldconfig config men=
uconfig defconfig \
>>  $(kconfig):
>>  	$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=3D$(XEN_TARGET_A=
RCH) $@
>> =20
>> -$(BASEDIR)/include/config/%.conf: $(BASEDIR)/include/config/auto.conf=
=2Ecmd
>> +$(BASEDIR)/include/config/%.conf: $(BASEDIR)/include/config/auto.conf=
=2Ecmd $(BASEDIR)/.config
>>  	$(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=3D$(XEN_TARG=
ET_ARCH) silentoldconfig
>> =20
>>  # Allow people to just run `make` as before and not force them to con=
figure
>> -$(BASEDIR)/.config $(BASEDIR)/include/config/auto.conf.cmd: ;
>> +$(BASEDIR)/.config:
>>  	$(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=3D$(XEN_TARG=
ET_ARCH) defconfig
>=20
> This should be one of the oldconfig targets now, shouldn't it?

oldconfig uses .config. This is the case when the user has checked out
the tree fresh. Its there to not change the workflow of "git clone ...
&& cd xen/xen && make"

>=20
>> +# Break the dependency chain for the first run
>> +$(BASEDIR)/include/config/auto.conf.cmd: ;
>> +
>> +-include $(BASEDIR)/include/config/auto.conf.cmd
>=20
> The comment is quite a bit different in Linux, and seems to make more
> sense. Also note how Linux has an empty rule for $(KCONFIG_CONFIG),
> a variable which iirc you defined in an earlier patch and hence perhaps=

> you should be using here.

I don't see where that's defined.

>=20
>> --- a/xen/include/xen/config.h
>> +++ b/xen/include/xen/config.h
>> @@ -12,6 +12,8 @@
>>  #endif
>>  #include <asm/config.h>
>> =20
>> +#include <generated/autoconf.h>
>=20
> First thing perhaps?
>=20
> Jan
>=20

Done.

--=20
Doug Goldstein


--8D6lsvG9FX2D3vg9TaenRctMUxuraDDC7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0

iQJ8BAEBCgBmBQJWZzVXXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB
MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUxf8P+wXAxaC56sVJpNMuON2lElXb
87OZ/O55gApZ7bBKjbJV7xAiNMUzGa+6XbggZAeFYuz2J5VmSyRxPS8mggTV9Frl
dZ9epwpCEK8Ob8ASmT8nq0iBbxAXOpdbvquOj2VWuUvgWcu3D7iddv34GYjl6Ltc
SnvirFMa5qGUq8lKJKIXO89dNZojvEK7iDX69pYC/pRbI9gpUD/ygr4SEC5nYrd5
SFIZSqUmWbZWTjIvqHjMevGPSxc4jrkgSmCtYHOSO7SCwfut7/rI86hTktukW6kZ
kamicku3FkKBME6BltMq9bgMFFKLidgO48DspSada11xeAzDxvNdyI/DwunKsPLf
M7h586GqicwZnwIAo+Nq8P1I+4XNQVEOYOhKZgK0cBBb8yMwLpIORubeCxWyl5t8
Rms9JiekqPOixZLLvD3rqLCeUrYIRMbLH0zKN2l0YOKMf/DmBEfyaB24x9UfVOJJ
3KdOldTufudiWWKyXt84lh5gjWaDWAvEm9G+fXhG+G8dYOPv3GbZo6CP5ZLEejQD
8O5XMtG1iUxE2oQ95QMVF+WZoCURVkwiKfbdzkfpEdrmtMyZ8BWCp796vyLQlQtz
hhz1w0rQR/8tBgPUKl9BWfthpYxbtpZt0Pk8jafo8zbKtDFPreRNblXdVhVmkEGc
fPquryYTmcdVj657u271
=2gH6
-----END PGP SIGNATURE-----

--8D6lsvG9FX2D3vg9TaenRctMUxuraDDC7--


--===============6776431496915422923==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6776431496915422923==--