From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753649AbbLJA4i (ORCPT ); Wed, 9 Dec 2015 19:56:38 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:57214 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbbLJA4f (ORCPT ); Wed, 9 Dec 2015 19:56:35 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79646d000001355-30-5668cdc1d5d7 Content-transfer-encoding: 8BIT Message-id: <5668CDC1.7080108@samsung.com> Date: Thu, 10 Dec 2015 09:56:33 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 04/19] ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk References: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> <1449634091-1842-5-git-send-email-cw00.choi@samsung.com> <5668CCF1.8080807@samsung.com> In-reply-to: <5668CCF1.8080807@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWyRsSkQPfg2Ywwg4//lC3mHznHatH/ZiGr xblXKxktXr8wtOh//JrZ4mzTG3aLy7vmsFl87j3CaDHj/D4mi3Ubb7Fb3L7Ma7H0+kUmi9uN K9gsJkxfy2LRuvcIu0Xb6g+sDgIea+atYfRoae5h87jc18vksXPWXXaPlcu/sHlsWtXJ5vHv GLtH35ZVjB6fN8kFcEZx2aSk5mSWpRbp2yVwZWyfv4it4Dx/xd7lv1gaGN/zdDFyckgImEgc v/qfEcIWk7hwbz1bFyMXh5DACkaJOad6mWGKjvR9ZYRIzGKUmHzhNRtIgldAUOLH5HssXYwc HMwC8hJHLmWDhJkF1CUmzVvEDFH/gFHiyMbLjBD1WhLz150Bs1kEVCU+dW8Fm8MGFN//4gYb yBxRgQiJ7hOVIGERgXiJTS+ugh3ELHCXSeLi+ydg9cICURJzGyeyQCxYwChxc+ElJpAEp4C2 xPJZM8AulRDYwiGx9vpBJohtAhLfJh8Cu1RCQFZi0wGozyQlDq64wTKBUWwWkn9mIfwzC8k/ CxiZVzGKphYkFxQnpRcZ6hUn5haX5qXrJefnbmIExvzpf896dzDePmB9iFGAg1GJh/eiS3qY EGtiWXFl7iFGU6AjJjJLiSbnAxNLXkm8obGZkYWpiamxkbmlmZI4r6LUz2AhgfTEktTs1NSC 1KL4otKc1OJDjEwcnFINjLf1jc6JX+z6G9jP9HmbSeT9qJf6C/+EONp3aM7rkpVOyK9+5PA8 N+fDKmdfsY0apqvWv4wzq/2y6v9RB2fbjXFMujEhK5dcPp1QMlnKueHms5617kfWpefHrC65 +K+tVzft2ZemV3Wl1Sr/e6adKK1kYDTPf2dTHpMd231fuZ4tfveyG9GblViKMxINtZiLihMB 9400MPQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHKsWRmVeSWpSXmKPExsVy+t9jQd2DZzPCDC7skLWYf+Qcq0X/m4Ws FuderWS0eP3C0KL/8Wtmi7NNb9gtLu+aw2bxufcIo8WM8/uYLNZtvMVucfsyr8XS6xeZLG43 rmCzmDB9LYtF694j7BZtqz+wOgh4rJm3htGjpbmHzeNyXy+Tx85Zd9k9Vi7/wuaxaVUnm8e/ Y+wefVtWMXp83iQXwBnVwGiTkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ib aqvk4hOg65aZA/SFkkJZYk4pUCggsbhYSd8O04TQEDddC5jGCF3fkCC4HiMDNJCwhjFj+/xF bAXn+Sv2Lv/F0sD4nqeLkZNDQsBE4kjfV0YIW0ziwr31bF2MXBxCArMYJSZfeM0GkuAVEJT4 MfkeSxcjBwezgLzEkUvZIGFmAXWJSfMWMUPUP2CUOLLxMiNEvZbE/HVnwGwWAVWJT91bweaw AcX3v7jBBjJHVCBCovtEJUhYRCBeYtOLq2B7mQXuMklcfP8ErF5YIEpibuNEFogFCxglbi68 xASS4BTQllg+awbjBEagMxHum4Vw3ywk9y1gZF7FKJFakFxQnJSea5SXWq5XnJhbXJqXrpec n7uJEZxWnknvYDy8y/0QowAHoxIP7wWX9DAh1sSy4srcQ4wSHMxKIrw6pzPChHhTEiurUovy 44tKc1KLDzGaAj04kVlKNDkfmPLySuINjU3MjCyNzA0tjIzNlcR5912KDBMSSE8sSc1OTS1I LYLpY+LglGpg9N47wVR7RwvTcfYN++/dULT1e/Ihb4/hRZbD+o68Ii8Fbnr8aXjkdfhktYPe 5w0pnQp57ttfT759P3vd7rroD/VBR597dl3W5HtiNv3SreCvYlWFB4LaFA68SAuNaf+eNft8 fFPRM8Wari3zdEsDl5a0Okieufzwzqve4n/7EpdYXnYvsz61V4mlOCPRUIu5qDgRAAuniX1B AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 10일 09:53, Krzysztof Kozlowski wrote: > On 09.12.2015 13:07, Chanwoo Choi wrote: >> This patch adds the DMC (Dynamic Memory Controller) bus frequency node >> which includes the devfreq-events and regulator properties. The bus >> frequency support the DVFS (Dynamic Voltage Frequency Scaling) feature >> with ondemand governor. >> >> The devfreq-events (ppmu_dmc0*) can monitor the utilization of DMC bus >> on runtime and the buck1_reg (VDD_MIF power line) supplies the power to >> the DMC block. >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm/boot/dts/exynos3250-monk.dts | 6 ++++++ >> arch/arm/boot/dts/exynos3250-rinato.dts | 6 ++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts >> index 443a35085846..d982586a6533 100644 >> --- a/arch/arm/boot/dts/exynos3250-monk.dts >> +++ b/arch/arm/boot/dts/exynos3250-monk.dts >> @@ -498,6 +498,12 @@ >> }; >> }; >> >> +&bus_dmc { >> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; >> + vdd-supply = <&buck1_reg>; >> + status = "okay"; >> +}; >> + >> &xusbxti { >> clock-frequency = <24000000>; >> }; >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts >> index 3e64d5dcdd60..61477943015b 100644 >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts >> @@ -675,6 +675,12 @@ >> }; >> }; >> >> +&bus_dmc { >> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; >> + vdd-supply = <&buck1_reg>; >> + status = "okay"; >> +}; > > I would prefer to put this in alphabetical order... which could be > tricky because the nodes are not entirely sorted. Maybe after the "&adc" > node? OK. I'll move it. > > Anyway the change looks good: > > Reviewed-by: Krzysztof Kozlowski Thanks for your review. Regards, Chanwoo Choi