From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751449AbbLJBbW (ORCPT ); Wed, 9 Dec 2015 20:31:22 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:24773 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbbLJBbU (ORCPT ); Wed, 9 Dec 2015 20:31:20 -0500 X-AuditID: cbfec7f4-f79026d00000418a-4e-5668d5e581a6 Subject: Re: [PATCH v2 09/19] PM / devfreq: exynos: Update documentation for bus devices using passive governor To: Chanwoo Choi , myungjoo.ham@samsung.com, kgene@kernel.org References: <1449634091-1842-1-git-send-email-cw00.choi@samsung.com> <1449634091-1842-10-git-send-email-cw00.choi@samsung.com> Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <5668D5DD.5090202@samsung.com> Date: Thu, 10 Dec 2015 10:31:09 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1449634091-1842-10-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsVy+t/xa7pPr2aEGdw8JGNx/ctzVov5R86x WvS/Wchqce7VSkaL1y8MLfofv2a2ONv0ht3i8q45bBafe48wWsw4v4/JYt3GW+wWty/zWiy9 fpHJ4nbjCjaLCdPXsli07j3CbtG2+gOrg6DHmnlrGD1amnvYPC739TJ57Jx1l91j5fIvbB6b VnWyefw7xu7Rt2UVo8fnTXIBnFFcNimpOZllqUX6dglcGZO2rGcsOKZTcXTbDtYGxrlKXYyc HBICJhIbn7xggbDFJC7cW8/WxcjFISSwlFFi2+MT7BDOL0aJo6cWA2U4OIQFCiXefVEFaRAR CJOYPeMHM0RNA6PE5zPTwLqZBe4ySVx8/4QNpIpNwFhi8/IlbBAr5CR6uyexgAziFdCS2NEj CxJmEVCV+NJ2BywsKhAhsWhHJkiYV0BQ4sfke2DHcQq4STy6sZcJpIRZQE/i/kUtkDCzgLzE 5jVvmScwCs5C0jELoWoWkqoFjMyrGEVTS5MLipPScw31ihNzi0vz0vWS83M3MULi78sOxsXH rA4xCnAwKvHwXnBJDxNiTSwrrsw9xCjBwawkwqt/OSNMiDclsbIqtSg/vqg0J7X4EKM0B4uS OO/cXe9DhATSE0tSs1NTC1KLYLJMHJxSDYxe8+q6jVYJOUyd69T4jvnqiQtLcq+WpU5uuShj 4NPdsvTSl0fzNgk37Qnd/uQ2h2iPXpW0DcOiNXtDDku+XL3Z0Mws6mvPT44jW45tuqymvT2W 8W+Woce3zWd9lzdeNN65uD24w/eh5KYFJ4oWRt70/MiwfFfeHh/+HbHHtMrz+npubqiJeKGj xFKckWioxVxUnAgAvu+g8rsCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.12.2015 13:08, Chanwoo Choi wrote: > This patch updates the documentation for passive bus devices and adds the > detailed example of Exynos3250. > > Signed-off-by: Chanwoo Choi > --- > .../devicetree/bindings/devfreq/exynos-bus.txt | 244 ++++++++++++++++++++- > 1 file changed, 241 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt > index 54a1f9c46c88..c4fdc70f8eac 100644 > --- a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt > +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt > @@ -13,18 +13,23 @@ SoC has the different sub-blocks. So, this difference should be specified > in devicetree file instead of each device driver. In result, this driver > is able to support the bus frequency for all Exynos SoCs. > > -Required properties for bus device: > +Required properties for all bus devices: > - compatible: Should be "samsung,exynos-bus". > - clock-names : the name of clock used by the bus, "bus". > - clocks : phandles for clock specified in "clock-names" property. > - #clock-cells: should be 1. > - operating-points-v2: the OPP table including frequency/voltage information > to support DVFS (Dynamic Voltage/Frequency Scaling) feature. > + > +Required properties for only parent bus device: Maybe: "Required properties only for parent bus devices:" In this binding documentation file the idea of "parent" is not explained. I now it is related to passive devfreq governor but looking at the binding itself it is a new idea, not covered here. > - vdd-supply: the regulator to provide the buses with the voltage. > - devfreq-events: the devfreq-event device to monitor the curret utilization > of buses. > > -Optional properties for bus device: > +Required properties for only passive bus device: "Required properties only for passive bus devices:" > +- devfreq: the parent bus device. > + > +Optional properties for only parent bus device: > - exynos,saturation-ratio: the percentage value which is used to calibrate > the performance count againt total cycle count. > > @@ -33,7 +38,20 @@ Example1: > power line (regulator). The MIF (Memory Interface) AXI bus is used to > transfer data between DRAM and CPU and uses the VDD_MIF regualtor. > > - - power line(VDD_MIF) --> bus for DMC (Dynamic Memory Controller) block > + - MIF (Memory Interface) block > + : VDD_MIF |--- DMC (Dynamic Memory Controller) > + > + - INT (Internal) block > + : VDD_INT |--- LEFTBUS (parent device) > + |--- PERIL > + |--- MFC > + |--- G3D > + |--- RIGHTBUS > + |--- FSYS > + |--- LCD0 > + |--- PERIR > + |--- ISP > + |--- CAM > > - MIF bus's frequency/voltage table > ----------------------- > @@ -46,6 +64,24 @@ Example1: > |L5| 400000 |875000 | > ----------------------- > > + - INT bus's frequency/voltage table > + ---------------------------------------------------------- > + |Block|LEFTBUS|RIGHTBUS|MCUISP |ISP |PERIL ||VDD_INT | > + | name| |LCD0 | | | || | > + | | |FSYS | | | || | > + | | |MFC | | | || | > + ---------------------------------------------------------- > + |Mode |*parent|passive |passive|passive|passive|| | > + ---------------------------------------------------------- > + |Lv |Frequency ||Voltage | > + ---------------------------------------------------------- > + |L1 |50000 |50000 |50000 |50000 |50000 ||900000 | > + |L2 |80000 |80000 |80000 |80000 |80000 ||900000 | > + |L3 |100000 |100000 |100000 |100000 |100000 ||1000000 | > + |L4 |134000 |134000 |200000 |200000 | ||1000000 | > + |L5 |200000 |200000 |400000 |300000 | ||1000000 | > + ---------------------------------------------------------- > + > Example2 : > The bus of DMC (Dynamic Memory Controller) block in exynos3250.dtsi > are listed below: > @@ -84,6 +120,167 @@ Example2 : > }; > }; > > + bus_leftbus: bus_leftbus { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu CLK_DIV_GDL>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_leftbus_opp_table>; > + status = "disabled"; > + }; > + > + bus_rightbus: bus_rightbus { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu CLK_DIV_GDR>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_leftbus_opp_table>; > + status = "disabled"; > + }; > + > + bus_lcd0: bus_lcd0 { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu CLK_DIV_ACLK_160>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_leftbus_opp_table>; > + status = "disabled"; > + }; > + > + bus_fsys: bus_fsys { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu CLK_DIV_ACLK_200>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_leftbus_opp_table>; > + status = "disabled"; > + }; > + > + bus_mcuisp: bus_mcuisp { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu CLK_DIV_ACLK_400_MCUISP>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_mcuisp_opp_table>; > + status = "disabled"; > + }; > + > + bus_isp: bus_isp { > + compatible = "samsung,exynos-bus"; > + clocks = <&cmu CLK_DIV_ACLK_266>; > + clock-names = "bus"; > + operating-points-v2 = <&bus_isp_opp_table>; > + status = "disabled"; > + }; > + > + bus_peril: bus_perir { Peril or perir? Best regards, Krzysztof