From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct Date: Thu, 10 Dec 2015 11:19:58 +0900 Message-ID: <5668E14E.8010302@samsung.com> References: <1449666760-29876-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:21940 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbbLJCUK (ORCPT ); Wed, 9 Dec 2015 21:20:10 -0500 In-reply-to: <1449666760-29876-1-git-send-email-linus.walleij@linaro.org> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij , linux-gpio@vger.kernel.org, Johan Hovold , Alexandre Courbot , Michael Welling , Markus Pargmann , Anton Vorontsov Cc: arm@kernel.org, Lee Jones , Alexander Shiyan , Shawn Guo , Sascha Hauer , Tony Lindgren , Kukjin Kim , Alexandre Courbot , Gregory Fong , Brian Norris , Florian Fainelli , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Nicolas Pitre , Olof Johansson , Vladimir Zapolskiy , Rabin Vincent , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com On 09.12.2015 22:12, Linus Walleij wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a struct, making several > steps of dereferencing necessary. > > Make things simpler: include the fields directly into > , #ifdef:ed for CONFIG_GENERIC_GPIO, and > get rid of the altogether. Prefix > some of the member variables with bgpio_* and add proper > kerneldoc while we're at it. > > Modify all users to handle the change and use a struct > gpio_chip directly. And while we're at it: replace all > container_of() dereferencing by gpiochip_get_data() and > registering the gpio_chip with gpiochip_add_data(). > > Cc: arm@kernel.org > Cc: Lee Jones > Cc: Alexander Shiyan > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Tony Lindgren > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Alexandre Courbot > Cc: Gregory Fong > Cc: Brian Norris > Cc: Florian Fainelli > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: Nicolas Pitre > Cc: Olof Johansson > Cc: Vladimir Zapolskiy > Cc: Rabin Vincent > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: bcm-kernel-feedback-list@broadcom.com > Signed-off-by: Linus Walleij > --- > ARM SoC folks and Lee: it would be great if you could > ACK the few lines hitting arch/arm/* and drivers/mfd/* in this > so I can take it through the GPIO tree. > --- > arch/arm/mach-clps711x/board-autcpu12.c | 2 +- > arch/arm/mach-clps711x/board-p720t.c | 2 +- > arch/arm/mach-imx/mach-mx21ads.c | 2 +- > arch/arm/mach-omap1/board-ams-delta.c | 2 +- > arch/arm/mach-s3c64xx/mach-crag6410.c | 2 +- For s3c64xx: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Thu, 10 Dec 2015 11:19:58 +0900 Subject: [PATCH 004/182] gpio: generic: factor into gpio_chip struct In-Reply-To: <1449666760-29876-1-git-send-email-linus.walleij@linaro.org> References: <1449666760-29876-1-git-send-email-linus.walleij@linaro.org> Message-ID: <5668E14E.8010302@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09.12.2015 22:12, Linus Walleij wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a struct, making several > steps of dereferencing necessary. > > Make things simpler: include the fields directly into > , #ifdef:ed for CONFIG_GENERIC_GPIO, and > get rid of the altogether. Prefix > some of the member variables with bgpio_* and add proper > kerneldoc while we're at it. > > Modify all users to handle the change and use a struct > gpio_chip directly. And while we're at it: replace all > container_of() dereferencing by gpiochip_get_data() and > registering the gpio_chip with gpiochip_add_data(). > > Cc: arm at kernel.org > Cc: Lee Jones > Cc: Alexander Shiyan > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Tony Lindgren > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Alexandre Courbot > Cc: Gregory Fong > Cc: Brian Norris > Cc: Florian Fainelli > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: Nicolas Pitre > Cc: Olof Johansson > Cc: Vladimir Zapolskiy > Cc: Rabin Vincent > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-omap at vger.kernel.org > Cc: linux-samsung-soc at vger.kernel.org > Cc: bcm-kernel-feedback-list at broadcom.com > Signed-off-by: Linus Walleij > --- > ARM SoC folks and Lee: it would be great if you could > ACK the few lines hitting arch/arm/* and drivers/mfd/* in this > so I can take it through the GPIO tree. > --- > arch/arm/mach-clps711x/board-autcpu12.c | 2 +- > arch/arm/mach-clps711x/board-p720t.c | 2 +- > arch/arm/mach-imx/mach-mx21ads.c | 2 +- > arch/arm/mach-omap1/board-ams-delta.c | 2 +- > arch/arm/mach-s3c64xx/mach-crag6410.c | 2 +- For s3c64xx: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof