* + test_hexdump-switch-to-memcmp.patch added to -mm tree
@ 2015-12-10 0:31 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2015-12-10 0:31 UTC (permalink / raw)
To: andriy.shevchenko, mm-commits
The patch titled
Subject: test_hexdump: switch to memcmp()
has been added to the -mm tree. Its filename is
test_hexdump-switch-to-memcmp.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/test_hexdump-switch-to-memcmp.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/test_hexdump-switch-to-memcmp.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: test_hexdump: switch to memcmp()
Better to use memcmp() against entire buffer to check that nothing is
happened to the data in the tail.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/test_hexdump.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN lib/test_hexdump.c~test_hexdump-switch-to-memcmp lib/test_hexdump.c
--- a/lib/test_hexdump.c~test_hexdump-switch-to-memcmp
+++ a/lib/test_hexdump.c
@@ -72,8 +72,6 @@ static void __init test_hexdump_prepare_
else
result = test_data_1_le;
- memset(test, FILL_CHAR, testlen);
-
/* hex dump */
p = test;
for (i = 0; i < l / gs; i++) {
@@ -109,13 +107,15 @@ static void __init test_hexdump(size_t l
char test[TEST_HEXDUMP_BUF_SIZE];
char real[TEST_HEXDUMP_BUF_SIZE];
+ memset(real, FILL_CHAR, sizeof(real));
hex_dump_to_buffer(data_b, len, rowsize, groupsize, real, sizeof(real),
ascii);
+ memset(test, FILL_CHAR, sizeof(test));
test_hexdump_prepare_test(len, rowsize, groupsize, test, sizeof(test),
ascii);
- if (strcmp(test, real)) {
+ if (memcmp(test, real, TEST_HEXDUMP_BUF_SIZE)) {
pr_err("Len: %zu row: %d group: %d\n", len, rowsize, groupsize);
pr_err("Result: '%s'\n", real);
pr_err("Expect: '%s'\n", test);
_
Patches currently in -mm which might be from andriy.shevchenko@linux.intel.com are
test_hexdump-rename-to-test_hexdump.patch
test_hexdump-introduce-test_hexdump_prepare_test-helper.patch
test_hexdump-define-fill_char-constant.patch
test_hexdump-go-through-all-possible-lengths-of-buffer.patch
test_hexdump-replace-magic-numbers-by-their-meaning.patch
test_hexdump-switch-to-memcmp.patch
test_hexdump-check-all-bytes-in-real-buffer.patch
test_hexdump-test-all-possible-group-sizes-for-overflow.patch
test_hexdump-print-statistics-at-the-end.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-12-10 0:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-10 0:31 + test_hexdump-switch-to-memcmp.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.