All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/4] ARM: at91: armv7: clean up UTMI PLL handle code
Date: Thu, 10 Dec 2015 10:36:48 +0100	[thread overview]
Message-ID: <566947B0.8000909@denx.de> (raw)
In-Reply-To: <1449647855-1986-3-git-send-email-wenyou.yang@atmel.com>

Hello Wenyou,

Am 09.12.2015 um 08:57 schrieb Wenyou Yang:
> Due to introducing the UTMI PLL enable function, use this function
> to reduce the duplicated code.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> Changes in v2: None
>
>   arch/arm/mach-at91/armv7/sama5d2_devices.c |    5 +----
>   arch/arm/mach-at91/armv7/sama5d3_devices.c |    5 +----
>   arch/arm/mach-at91/armv7/sama5d4_devices.c |    5 +----
>   3 files changed, 3 insertions(+), 12 deletions(-)

Tested on the smartweb board, see log:
http://xeidos.ddns.net/buildbot/builders/smartweb_dfu/builds/29/steps/shell/logs/tbotlog

Tested-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/arch/arm/mach-at91/armv7/sama5d2_devices.c b/arch/arm/mach-at91/armv7/sama5d2_devices.c
> index 88f8f2c..978eac2 100644
> --- a/arch/arm/mach-at91/armv7/sama5d2_devices.c
> +++ b/arch/arm/mach-at91/armv7/sama5d2_devices.c
> @@ -7,7 +7,6 @@
>
>   #include <common.h>
>   #include <asm/io.h>
> -#include <asm/arch/at91_pmc.h>
>   #include <asm/arch/clk.h>
>   #include <asm/arch/sama5d2.h>
>
> @@ -48,9 +47,7 @@ char *get_cpu_name()
>   #ifdef CONFIG_USB_GADGET_ATMEL_USBA
>   void at91_udp_hw_init(void)
>   {
> -	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
> -
> -	writel(AT91_PMC_UPLLEN | AT91_PMC_BIASEN, &pmc->uckr);
> +	at91_upll_clk_enable();
>
>   	at91_periph_clk_enable(ATMEL_ID_UDPHS);
>   }
> diff --git a/arch/arm/mach-at91/armv7/sama5d3_devices.c b/arch/arm/mach-at91/armv7/sama5d3_devices.c
> index 78ecfc8..64ac262 100644
> --- a/arch/arm/mach-at91/armv7/sama5d3_devices.c
> +++ b/arch/arm/mach-at91/armv7/sama5d3_devices.c
> @@ -8,7 +8,6 @@
>   #include <common.h>
>   #include <asm/arch/sama5d3.h>
>   #include <asm/arch/at91_common.h>
> -#include <asm/arch/at91_pmc.h>
>   #include <asm/arch/clk.h>
>   #include <asm/arch/gpio.h>
>   #include <asm/io.h>
> @@ -208,10 +207,8 @@ void at91_lcd_hw_init(void)
>   #ifdef CONFIG_USB_GADGET_ATMEL_USBA
>   void at91_udp_hw_init(void)
>   {
> -	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
> -
>   	/* Enable UPLL clock */
> -	writel(AT91_PMC_UPLLEN | AT91_PMC_BIASEN, &pmc->uckr);
> +	at91_upll_clk_enable();
>   	/* Enable UDPHS clock */
>   	at91_periph_clk_enable(ATMEL_ID_UDPHS);
>   }
> diff --git a/arch/arm/mach-at91/armv7/sama5d4_devices.c b/arch/arm/mach-at91/armv7/sama5d4_devices.c
> index ce33cd4..ebb779e 100644
> --- a/arch/arm/mach-at91/armv7/sama5d4_devices.c
> +++ b/arch/arm/mach-at91/armv7/sama5d4_devices.c
> @@ -8,7 +8,6 @@
>   #include <common.h>
>   #include <asm/io.h>
>   #include <asm/arch/at91_common.h>
> -#include <asm/arch/at91_pmc.h>
>   #include <asm/arch/clk.h>
>   #include <asm/arch/sama5_sfr.h>
>   #include <asm/arch/sama5d4.h>
> @@ -37,10 +36,8 @@ char *get_cpu_name()
>   #ifdef CONFIG_USB_GADGET_ATMEL_USBA
>   void at91_udp_hw_init(void)
>   {
> -	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
> -
>   	/* Enable UPLL clock */
> -	writel(AT91_PMC_UPLLEN | AT91_PMC_BIASEN, &pmc->uckr);
> +	at91_upll_clk_enable();
>   	/* Enable UDPHS clock */
>   	at91_periph_clk_enable(ATMEL_ID_UDPHS);
>   }
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2015-12-10  9:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09  7:57 [U-Boot] [PATCH v2 0/4] ARM: at91: add UTMI PLL handle functions Wenyou Yang
2015-12-09  7:57 ` [U-Boot] [PATCH v2 1/4] ARM: at91: clock: add UTMI PLL enable/disable function Wenyou Yang
2015-12-10  9:36   ` Heiko Schocher
2015-12-09  7:57 ` [U-Boot] [PATCH v2 2/4] ARM: at91: armv7: clean up UTMI PLL handle code Wenyou Yang
2015-12-10  9:36   ` Heiko Schocher [this message]
2015-12-09  7:57 ` [U-Boot] [PATCH v2 3/4] drivers: usb: atmel: clean up the UTMI PLL code Wenyou Yang
2015-12-10  9:37   ` Heiko Schocher
2015-12-09  7:57 ` [U-Boot] [PATCH v2 4/4] board: atmel: siemens: clean up " Wenyou Yang
2015-12-10  9:37   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566947B0.8000909@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.