From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCHv6] 03/28] build: use generated Kconfig
 options for Xen
Date: Thu, 10 Dec 2015 04:43:28 -0700
Message-ID: <5669737002000078000BE11E@prv-mh.provo.novell.com>
References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com>
	<1448387538-12208-4-git-send-email-cardoe@cardoe.com>
	<565C6F2402000078000BA43E@prv-mh.provo.novell.com>
	<56673554.7050309@cardoe.com>
	<5667F71F02000078000BD7A0@prv-mh.provo.novell.com>
	<56689038.8020000@cardoe.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56689038.8020000@cardoe.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

>>> On 09.12.15 at 21:34, <cardoe@cardoe.com> wrote:
> On 12/9/15 2:40 AM, Jan Beulich wrote:
>>>>> On 08.12.15 at 20:53, <cardoe@cardoe.com> wrote:
>>> On 11/30/15 8:45 AM, Jan Beulich wrote:
>>>>>>> On 24.11.15 at 18:51, <cardoe@cardoe.com> wrote:
>>>>> @@ -227,9 +230,14 @@ kconfig := silentoldconfig oldconfig config menuconfig defconfig \
>>>>>  $(kconfig):
>>>>>  	$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=$(XEN_TARGET_ARCH) $@
>>>>>  
>>>>> -$(BASEDIR)/include/config/%.conf: $(BASEDIR)/include/config/auto.conf.cmd
>>>>> +$(BASEDIR)/include/config/%.conf: $(BASEDIR)/include/config/auto.conf.cmd $(BASEDIR)/.config
>>>>>  	$(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=$(XEN_TARGET_ARCH) silentoldconfig
>>>>>  
>>>>>  # Allow people to just run `make` as before and not force them to configure
>>>>> -$(BASEDIR)/.config $(BASEDIR)/include/config/auto.conf.cmd: ;
>>>>> +$(BASEDIR)/.config:
>>>>>  	$(Q)$(MAKE) -f $(BASEDIR)/scripts/kconfig/Makefile ARCH=$(XEN_TARGET_ARCH) defconfig
>>>>
>>>> This should be one of the oldconfig targets now, shouldn't it?
>>>
>>> oldconfig uses .config. This is the case when the user has checked out
>>> the tree fresh. Its there to not change the workflow of "git clone ...
>>> && cd xen/xen && make"
>> 
>> Okay. But then this is meant to only support the simplest possible
>> form, i.e. without honoring any make command line or ./.config
>> overrides like debug=y or kexec=n? If that understanding of
>> mine is correct, at least the comment should mention such a
>> limitation (even better would be if in such cases unexpected
>> results would be prevented by - as the most trivial solution -
>> failing the build with a meaningful error message).
> 
> So you would like me to add code into xen/Makefile to detect if someone
> ran "make kexec=X" or added "kexec=X" into top level .config and give
> them a meaningful error message to tell them to use "make config" instead?

If you want to do the "(even better ...)" form, yes.

Jan