From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCHv6] 03/28] build: use generated Kconfig
 options for Xen
Date: Thu, 10 Dec 2015 04:45:32 -0700
Message-ID: <566973EC02000078000BE121@prv-mh.provo.novell.com>
References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com>
	<1448387538-12208-4-git-send-email-cardoe@cardoe.com>
	<565C6F2402000078000BA43E@prv-mh.provo.novell.com>
	<56673554.7050309@cardoe.com>
	<5667F71F02000078000BD7A0@prv-mh.provo.novell.com>
	<56689038.8020000@cardoe.com> <566894AF.7080509@cardoe.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <566894AF.7080509@cardoe.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

>>> On 09.12.15 at 21:53, <cardoe@cardoe.com> wrote:
> On 12/9/15 2:34 PM, Doug Goldstein wrote:
>> So you would like me to add code into xen/Makefile to detect if someone
>> ran "make kexec=X" or added "kexec=X" into top level .config and give
>> them a meaningful error message to tell them to use "make config" instead?
> 
> So I need to clarify here. If you do want this, then do you have a
> suggestion how I can detect when someone uses the .config file to
> override this? $(origin) returns the same value for me in that case. For
> "make kexec=n" I can detect that with $(origin).

Well, it would seem to me that checking for just the non-default case
would be sufficient, i.e. without any $(origin ...), but just looking at
the values.

Jan