From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70gc-0007KD-SI for qemu-devel@nongnu.org; Thu, 10 Dec 2015 07:51:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a70gX-0005m9-Pf for qemu-devel@nongnu.org; Thu, 10 Dec 2015 07:51:06 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:34422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70gX-0005m4-J4 for qemu-devel@nongnu.org; Thu, 10 Dec 2015 07:51:01 -0500 Received: by mail-wm0-x231.google.com with SMTP id v187so31517678wmv.1 for ; Thu, 10 Dec 2015 04:51:01 -0800 (PST) References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <1449704528-289297-2-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <56697532.1010101@gmail.com> Date: Thu, 10 Dec 2015 14:50:58 +0200 MIME-Version: 1.0 In-Reply-To: <1449704528-289297-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org On 12/10/2015 01:40 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 6d37332..50678b5 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -580,6 +580,13 @@ static void test_acpi_asl(test_data *data) > (gchar *)&signature, > sdt->asl_file, sdt->aml_file, > exp_sdt->asl_file, exp_sdt->aml_file); > + if (getenv("V")) { > + int ret G_GNUC_UNUSED; > + char *diff = g_strdup_printf("git diff --exit-code %s %s", > + exp_sdt->asl_file, sdt->asl_file); > + ret = system(diff) ; > + g_free(diff); > + } > } > } > g_string_free(asl, true); > Reviewed-by: Marcel Apfelbaum