From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulanit Subject: Re: [PATCH v6 4/4] gicv2m: acpi: Introducing GICv2m ACPI support Date: Thu, 10 Dec 2015 10:11:01 -0600 Message-ID: <5669A415.60300@amd.com> References: <1449689074-30609-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1449689074-30609-5-git-send-email-Suravee.Suthikulpanit@amd.com> <56694272.5050706@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-by2on0096.outbound.protection.outlook.com ([207.46.100.96]:19264 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750790AbbLJQLJ (ORCPT ); Thu, 10 Dec 2015 11:11:09 -0500 In-Reply-To: <56694272.5050706@arm.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Marc Zyngier , tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net Cc: Lorenzo Pieralisi , Will Deacon , Catalin Marinas , hanjun.guo@linaro.org, tomasz.nowicki@linaro.org, graeme.gregory@linaro.org, dhdang@apm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org On 12/10/2015 3:14 AM, Marc Zyngier wrote: >> +int __init gicv2m_init(struct fwnode_handle *parent_handle, >> >+ struct irq_domain *parent) >> >+{ >> >+ int ret = gicv2m_of_init(parent_handle, parent); >> >+ >> >+ if (ret) >> >+ ret = gicv2m_acpi_init(parent); >> >+ return ret; > This should really read: > > if (is_of_node(parent_handle)) > return gicv2m_of_init(parent_handle, parent); > > return gicv2m_acpi_init(parent); > > and you can loose the test for NULL in gicv2m_of_init(). > Right... Your style of returning which is cleaner ;) I'll update in V7 and send it out shortly. Thanks, Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbbLJQLM (ORCPT ); Thu, 10 Dec 2015 11:11:12 -0500 Received: from mail-by2on0096.outbound.protection.outlook.com ([207.46.100.96]:19264 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750790AbbLJQLJ (ORCPT ); Thu, 10 Dec 2015 11:11:09 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v6 4/4] gicv2m: acpi: Introducing GICv2m ACPI support To: Marc Zyngier , , , References: <1449689074-30609-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1449689074-30609-5-git-send-email-Suravee.Suthikulpanit@amd.com> <56694272.5050706@arm.com> CC: Lorenzo Pieralisi , Will Deacon , Catalin Marinas , , , , , , , From: Suravee Suthikulanit Message-ID: <5669A415.60300@amd.com> Date: Thu, 10 Dec 2015 10:11:01 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56694272.5050706@arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BLUPR13CA0049.namprd13.prod.outlook.com (25.160.82.20) To CY1PR12MB0444.namprd12.prod.outlook.com (25.163.91.22) X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0444;2:tbxoZGlrYo9bgOav/4e53GSWli28uQa9g6WlEbjRxm4JJdGMDApRYRspva18bwrOxuj61Rrv7r7nI4pAPHf8683xJWoW5lPum/ycWj0KgzQPU1wi/6icJkRgop6vmfyY41rDcpWge1SXMQxHhien3g==;3:OuyL9Kpv0SvbKC+oxhR2WP70hiw91hcRYe/RnbepobscWGTUycer5RuWOsqJr2o2E+j44kn6HixLzvlCt4i+iU3HOGeu534PLaaId0tEBVESbwlDHXZrCWZ9mhBsvGTA;25:Lpn178lmGZiDVDSCRzCqIAHON8ggzhRYVXN9nQTjy2FgPnHYqRTD5eFxFGXJiljuFLy6rBw7V4eFcwyaf73H+BD3bv7tk3E4BxGAPRzEUXBkwCsRTy0RZoeHseZI0X+B3DD2KOLgHw4dNlUPfIjqghoudhQwSN53KbU5yMBEefWmf+wSCLHZS/apCeWKiyTzZcoqLTMjWRCXRhFS1EmKS/NDYOlocwRQIopMelxUU6lb/qV4cSLzMekjWmBERgvYIWTzGEcJCY5ewyANqSS5NA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0444; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0444;20:/l/GB1PvsF2AuitZd4Tu75HS3aP6t79dPh0jI18Hwpvyj5yOnY9se+TAw4g+ZeQuxbR1J23IoRVWIjZf1C500olkNYl7V+k6nXzpmZfZQ+3jBwMktdytNMvL/FAI4X984huHuTKrLz3bDQTAL1W4r7LpcPlEd7Yj43nL+t5WY1BAr321Cd7nNJl+zLSH5bqkm+AJFgvlZImzduz3J/i5/+QWBuYwX3npkdlxcxHMh1XDlA4tEFV+UWlz3eJyDTFgIS2/NGKJuN0sPHLxkpPSz69fpv6EDeNNE/82v91W4zDBm7JG+6Q91kjTaYZoBgtkhB0t8FMBRm2f6u5Rf+mruXVguGL7IkN5kkoTRpY93jLUfV1cNzhNu9y0kQ0zJLSSoJ5OT1AEeSzZE6KYgnSDp7vyrqI6zC61js9AtxZfrHt5rjAT5vtVbn8cd69IVIyHtSZJcG99NeD85YZWnm0e5/gaUQDa+qXrbaWSbz+BeCqGLoxTFX/mCiXxYTVDZmRZ;4:hJ852GejfoyLpaEKMPLVYibKnunKsr0EDHD+RhHqUtv5JFbMLUp1K/MNmFKSooz5x1TEB/OijgcffXxszRVJGuZTtS2UVKIHWjl3MeyzGOruYRouCOi2Z046MaX3a19zwFClXYuvDwtEQQSjpTAU7rID9s0NF6edTELdULy2TLM6WUEd6Twr6nkcR8xOasW35tmYf+DHRfyqlwieLmlajMR8pGtbagCOgYKT60ewV9LidDNPCXAKdKu592T0oIV3K1uSRQ8uk2hvNg/qW2eXjO+oLfNo681gsWgZpxxgK5GhGRGPU4/7dDeo74HKkUfUTSQfepBPKZSLohe/i/icDblDNLdeNWNqsaK629C4htkE9rJkQtQU/zCa3h6GqlGD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY1PR12MB0444;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0444; X-Forefront-PRVS: 078693968A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(6009001)(6049001)(199003)(189002)(479174004)(24454002)(164054003)(377454003)(65956001)(105586002)(87976001)(40100003)(65806001)(23746002)(122386002)(42186005)(106356001)(47776003)(66066001)(97736004)(65816999)(4001350100001)(101416001)(5008740100001)(230700001)(5004730100002)(5001770100001)(5001960100002)(81156007)(50986999)(77096005)(2950100001)(33656002)(2201001)(54356999)(92566002)(189998001)(76176999)(86362001)(3846002)(1096002)(83506001)(36756003)(586003)(50466002)(64126003)(6116002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0444;H:[10.236.18.83];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR12MB0444;23:cCzrVlRGWiAcv+H2Q2QnqpQr15wmkdZ5KcaFT?= =?Windows-1252?Q?VL0ZjGQBt8GO5HeCUrjFFH24cCSAXwyoEKf+HXw2yNe2jxVhqHZrAdb8?= =?Windows-1252?Q?oPf/Ly5naz2PwLOnqC/h3dGjRA2oWZkjUGMe1A1iKX1pl9nAOHBKT1p4?= =?Windows-1252?Q?koGOJ/otvMcBtj8XNpiZ1EFM68UHB/wjMkwb9dOL6HTTH10ecPwgyhrr?= =?Windows-1252?Q?Bqm85/mYrt6BDRWMzy1kwbe24nz3bm8iQsE4X5kMosvp5q7HnWAEBemN?= =?Windows-1252?Q?A3X5Apt2Vg0MVv8/OdoS/q40Y6S1LGbXu4T5UkkscpV8ADvURDHnVWuC?= =?Windows-1252?Q?oDPlhjwTzQTcm98vouqqm236MQTLzsDqnCxh4eJ8ReIiy8lqYDwlD0UN?= =?Windows-1252?Q?mvJwOV12TpR0mZv5gmx43F4N0UUg/nIbxCwyca8nhAbJ7Ja7TQQxDoyo?= =?Windows-1252?Q?sG3ceV8Co4SQyPeI6pGxN/2rDoM7TNvcJlMpWqtSca8RN3CrKkvPhrDr?= =?Windows-1252?Q?pCQYP4Bv6vzF6jxz8C85QGKJrbsnGkkO2JBxfmdueP28A71O2ovIeC6N?= =?Windows-1252?Q?iOI9A+SK5rgamT/l714XA6mEo5KByaJruqfjC1q1o7Vz4ndU2KNdfFRM?= =?Windows-1252?Q?lNxxpyeivVSzYXw6hO988hCb6ZIUzzGWAhK+otcQTZ6gTZC5zFAbIJiq?= =?Windows-1252?Q?F6O7XDkiKtOnwQQLJyvfaAvwZHpXmVFnIQHZMIp9bUj0O1MuVZqt+yIl?= =?Windows-1252?Q?OuVPgfheEiwRwmTE5PavWmofpw8w8+iJPO5pM7yS7n1ie3OIl+8ctY1L?= =?Windows-1252?Q?KxR0DwbQzSd2C77clubHzrN2wpb9jTIarAD2z5pR4poF1inBZ8szpIuq?= =?Windows-1252?Q?8J6TQFm8FDVIU7Nah3qD5tvIRhmpuknw0eUAZFXeJL9nvpTtKMwEL7v8?= =?Windows-1252?Q?08l0eOBYvBc4DhM3OWe2siHM0QuYnYj9uemZsBYXBg1wKeJzc0HZmVVc?= =?Windows-1252?Q?g3pAKDwNWUH217fz9EcWTVdq7i/LXjdAN1bLn84xzFHtwclJR1mVROVO?= =?Windows-1252?Q?58MafeMq3/v2ygAi0MFwBcOGo4Sfr85FhBFnT48SlE66kdnjQ7Pf2Iu9?= =?Windows-1252?Q?KqBPrnEYZwiQXWCS6Jh7rE4f9aVhFFPHtdVI41CySdlD2lyF1aaWj8DN?= =?Windows-1252?Q?D2ETHDmYutmmmWHb2mowpyZIe4lKZTl1NqeR16nQ3u7RAUKXEkINY9sI?= =?Windows-1252?Q?aDU/lnR2OO9SRlf6rMQbmy/qCFE/d+eJAjpetgl+tZfZmEY4O+JmroTf?= =?Windows-1252?Q?l5SHOoluz7h+MUmJwdVoC3DE+R8wrwwsFzmLx+yVNKNbRGWqzuoLLCkK?= =?Windows-1252?Q?6V+NNMVcHDhWyiseBG3UKcF2FN0/J+ufWTeXnPFJSK3GLbQopITv4k?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0444;5:bysabDCfUQeR8MnbN8maZoQWlRFtmndsZs8TVVFOEo8pfIl098STE5eA6M4TXp14pYj+UQz/3zYHqvRNcQx0T3JqHk6Pl052soyHu6AiNjIVRNLCYBa/fhB66ph0D3Jew2a1xrX1ZvdsCnW7/JgSJA==;24:uZL/K8Zqb3ysEMAaoMWuYC6XnR+pjiNWvfLOL84zc2x4cVdj18C6hXT1WL52ttt5PTFyBJ7eZiTw1vkZ+qYhC+p6IApcAq/fQkM6SGWgjPw=;20:0NA+kKrmA4Na9ApySSd+jmy8mn9Qs1LeMHdsuNcSjRqSpS/49QtEmUhAtao84kONWu3hbVjXPngel8dIcRY3rXTemJIJ3Vg2co3dZ37L1dmSmjieeKNEEtqWdllpC3cURRh41SgE3sPxpZd+PVTqh11tBh9bq8vXE3W0FAzXL724zs/g5yfYOvzhokSptoB43O6fUuQU+Osuq/W6JeSlKDPRxSRRKq2uCdnVRWrOehfy46PDypXvh5/E8iw3k6+y SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2015 16:11:04.8939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0444 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/2015 3:14 AM, Marc Zyngier wrote: >> +int __init gicv2m_init(struct fwnode_handle *parent_handle, >> >+ struct irq_domain *parent) >> >+{ >> >+ int ret = gicv2m_of_init(parent_handle, parent); >> >+ >> >+ if (ret) >> >+ ret = gicv2m_acpi_init(parent); >> >+ return ret; > This should really read: > > if (is_of_node(parent_handle)) > return gicv2m_of_init(parent_handle, parent); > > return gicv2m_acpi_init(parent); > > and you can loose the test for NULL in gicv2m_of_init(). > Right... Your style of returning which is cleaner ;) I'll update in V7 and send it out shortly. Thanks, Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 From: suravee.suthikulpanit@amd.com (Suravee Suthikulanit) Date: Thu, 10 Dec 2015 10:11:01 -0600 Subject: [PATCH v6 4/4] gicv2m: acpi: Introducing GICv2m ACPI support In-Reply-To: <56694272.5050706@arm.com> References: <1449689074-30609-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1449689074-30609-5-git-send-email-Suravee.Suthikulpanit@amd.com> <56694272.5050706@arm.com> Message-ID: <5669A415.60300@amd.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/10/2015 3:14 AM, Marc Zyngier wrote: >> +int __init gicv2m_init(struct fwnode_handle *parent_handle, >> >+ struct irq_domain *parent) >> >+{ >> >+ int ret = gicv2m_of_init(parent_handle, parent); >> >+ >> >+ if (ret) >> >+ ret = gicv2m_acpi_init(parent); >> >+ return ret; > This should really read: > > if (is_of_node(parent_handle)) > return gicv2m_of_init(parent_handle, parent); > > return gicv2m_acpi_init(parent); > > and you can loose the test for NULL in gicv2m_of_init(). > Right... Your style of returning which is cleaner ;) I'll update in V7 and send it out shortly. Thanks, Suravee