Re: [PATCH v2 2/2] VT-d: Fix vt-d flush timeout issue.

From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Quan Xu <quan.xu@intel.com>, jbeulich@suse.com, kevin.tian@intel.com
Cc: feng.wu@intel.com, george.dunlap@eu.citrix.com, tim@xen.org,
	eddie.dong@intel.com, xen-devel@lists.xen.org,
	jun.nakajima@intel.com, keir@xen.org
Subject: Re: [PATCH v2 2/2] VT-d: Fix vt-d flush timeout issue.
Date: Thu, 10 Dec 2015 19:05:17 +0000	[thread overview]
Message-ID: <5669CCED.6000609@citrix.com> (raw)
In-Reply-To: <1449739990-66155-3-git-send-email-quan.xu@intel.com>

On 10/12/15 09:33, Quan Xu wrote:
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
> index a5aef55..0bf6b1a 100644
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -41,6 +41,7 @@
>  struct pci_dev_info {
>      bool_t is_extfn;
>      bool_t is_virtfn;
> +    bool_t is_unassignable;
>      struct {
>          u8 bus;
>          u8 devfn;
> @@ -88,6 +89,12 @@ struct pci_dev {
>  #define for_each_pdev(domain, pdev) \
>      list_for_each_entry(pdev, &(domain->arch.pdev_list), domain_list)
>  
> +#define PDEV_UNASSIGNABLE 1
> +#define mark_pdev_unassignable(pdev) \
> +    pdev->info.is_unassignable = PDEV_UNASSIGNABLE
> +
> +#define IS_PDEV_UNASSIGNABLE(pdev) pdev->info.is_unassignable

Static inlines please.

These macros lack any hygene whatsoever, but don't need to be macros in
the first place.

~Andrew