From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7Ex5-0001y7-2j for qemu-devel@nongnu.org; Thu, 10 Dec 2015 23:05:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7Ex1-0000yE-TH for qemu-devel@nongnu.org; Thu, 10 Dec 2015 23:05:03 -0500 References: <1449546921-6378-1-git-send-email-eblake@redhat.com> <1449546921-6378-30-git-send-email-eblake@redhat.com> <5669B71E.80102@redhat.com> From: Eric Blake Message-ID: <566A4B64.8030904@redhat.com> Date: Thu, 10 Dec 2015 21:04:52 -0700 MIME-Version: 1.0 In-Reply-To: <5669B71E.80102@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BBMXABXnomHrFfQrxFmPIJb3cFSNGS1VS" Subject: Re: [Qemu-devel] [PATCH v7 29/31] qapi: Simplify semantics of visit_next_list() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Roth , Alexander Graf , "open list:sPAPR pseries" , armbru@redhat.com, David Gibson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BBMXABXnomHrFfQrxFmPIJb3cFSNGS1VS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/10/2015 10:32 AM, Eric Blake wrote: > On 12/07/2015 08:55 PM, Eric Blake wrote: >=20 >> We can greatly simplify things by hoisting the special case >> into the start() routine, and flipping the order in the loop >> to visit before advance: >> >> start(head) >> element =3D *head >> while (element) { >> visit(element) >> element =3D next(element) >> } >> > Looking at this, it is inconsistent with start_struct (where name comes= > AFTER the object); that is, I think this should probably be: >=20 > void (*start_list)(Visitor *v, GenericList **list, const char *name, > Error **errp); >=20 > although I'll still wait for review comments before respinning. I've also bisected this patch as causing assertion failures in qemu-iotests 041 and 139, so I'll have to sort that out on the respin. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BBMXABXnomHrFfQrxFmPIJb3cFSNGS1VS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWaktkAAoJEKeha0olJ0NqWggH/06/clS5hm+wU7EWMU6QaGjv sCAKOTxAFAfEPtdrGS0aw9EtwAX2Sz+I9Iq2qQixxPCt6wkw1/1pQPLCME38foZo 1eXfl/FFSl8iHFr8cx30/zGSUoi54p7i6DnF9FcL0iZxjBruWul25aZaePbwpEMR XKios84aTAdIeyudWFLEDNPfcWr0aRgxv6MbcdzS/X6dEEjgLtriHXNNvcwNpln6 Qp0KemRoe23ic4U6Dk2n9wAfDtW3eX8oQlvnPxChYpUvLg5I47XXykqz4G3pLgKH jGgDfa/B9/7oVE623aWf+jhC4vN4IUbCLvd599XewaaF78Rm9wJwezGsFZsYeGY= =eLoE -----END PGP SIGNATURE----- --BBMXABXnomHrFfQrxFmPIJb3cFSNGS1VS--