From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbbLLPCZ (ORCPT ); Sat, 12 Dec 2015 10:02:25 -0500 Received: from mout.web.de ([212.227.15.4]:63790 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbbLLPCW (ORCPT ); Sat, 12 Dec 2015 10:02:22 -0500 Subject: Re: [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_params() To: Julia Lawall References: <566ABCD9.1060404@users.sourceforge.net> <566C2F7B.6030704@users.sourceforge.net> <566C3225.4070100@users.sourceforge.net> Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, "Nicholas A. Bellinger" , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <566C36F8.7040704@users.sourceforge.net> Date: Sat, 12 Dec 2015 16:02:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:49H1fUgyJ7pt7Z+aoALXi6YVOR0vcBsMOV2kI2E7u51Q8IQH10S 1YlvZNSzi15imMUxjyej1stzAqGrn8Zrgk96nFgt8aM8cNklofFynbIrahl5NLWDgdy+xPZ hc2bJ3DaO/01Bzgmv+nyvu1MSHgGbnvghv7rNVobxlPzrWbq82B0DybD8QJM1ZfJnsQUgry J/DyyyZ/Fv+bX5Uq7nhog== X-UI-Out-Filterresults: notjunk:1;V01:K0:mIRWmMCIKIY=:n/rF8cR9cBawzogW+HE7xc BtQoHo+s3SC3rvZXICCbX5+/GWk2+6L1pBj79MnGRFdGNF+OxpOhpCusZ70YtIwghfl6cxscT HQi5pV5p8AoD8ch4CEEUq3kERDS8GCQaIIiW3mLFazTRVAQIjHdYfBbbeD55qhl4GO2fntZIh 0/3XgI6icOaR6ArSxFAUgkqyW7ox6DcfKPjozKCbmArRqyPchuxiUUGlqXLDWEo1DfNf6PK80 Cd9bUcVQmc/kPzIJEHtx/amDLrHLaW3e1ZkrIPRWOGP97YHya5IeBEP1fkAW13YbB9UzeSvoF L7PrwqgBxo3Jo+ySwjP5Ko+AxirV2gygz8oM4AGvZJyAd73hSklKnR7ASO/Y3kQMYvqgVgdSx Sk7+ckWj/kbzxThecDMioXGhxOFEv2s5y08DDxvkW+fZvLb8cRyax5aBJ/cabZOe0VFKCc4iZ 6+MzNQ4koDAAVXLrENM7NMwa0oNbIJzAkOvh+oNDPnrlnUD2+Xjfd7H2M7kQhNoE3J9q+b9qB TQur7GB2cx1/MqTaOoDImwHOSXJ+5wVHUUBXH8/jQxa1cZ4PfnIas/ZIs04cZcZYz/cA9rO6y +9e26TwAfRlgOCv2kHJ6dMCdEywb3Hfp1YxTYefHRDFLeNGtyDHyipY0hVKKSb5V6ksEHeVeQ X2LajVEkLwdXlC1U/Fy4fyE2bUXPSM/QCvw/5RJIOjekZ2XjTuxurrcnabFxy+tccPiLjIw6x seDQYcx/zvrR+5FXkGDSDDkssX8MKUHTd9PF+oT4ZpQ+Hvlgsr4lbf1kEv0+4YCCtfsqNr4yY cWbqKzu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> @@ -200,9 +200,8 @@ free_param: >> int iscsi_create_default_params(struct iscsi_param_list **param_list_ptr) >> { >> struct iscsi_param *param; >> - struct iscsi_param_list *pl; >> + struct iscsi_param_list *pl = kzalloc(sizeof(*pl), GFP_KERNEL); >> >> - pl = kzalloc(sizeof(struct iscsi_param_list), GFP_KERNEL); > > I don't see the benefit of this change, and the pattern assignment -> > failure test becomes more obscure. Are there any more software developers who prefer to specify such a variable initialisation on a single line? Does the proposed small source code reduction matter for you? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 12 Dec 2015 15:02:16 +0000 Subject: Re: [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_defa Message-Id: <566C36F8.7040704@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <566C2F7B.6030704@users.sourceforge.net> <566C3225.4070100@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, "Nicholas A. Bellinger" , LKML , kernel-janitors@vger.kernel.org >> @@ -200,9 +200,8 @@ free_param: >> int iscsi_create_default_params(struct iscsi_param_list **param_list_ptr) >> { >> struct iscsi_param *param; >> - struct iscsi_param_list *pl; >> + struct iscsi_param_list *pl = kzalloc(sizeof(*pl), GFP_KERNEL); >> >> - pl = kzalloc(sizeof(struct iscsi_param_list), GFP_KERNEL); > > I don't see the benefit of this change, and the pattern assignment -> > failure test becomes more obscure. Are there any more software developers who prefer to specify such a variable initialisation on a single line? Does the proposed small source code reduction matter for you? Regards, Markus