From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752745AbbLNJIX (ORCPT ); Mon, 14 Dec 2015 04:08:23 -0500 Received: from mout.web.de ([212.227.15.3]:60975 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932093AbbLNJIU (ORCPT ); Mon, 14 Dec 2015 04:08:20 -0500 Subject: Re: [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls To: Dan Carpenter References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <566D7884.5050407@users.sourceforge.net> <20151214065325.GS5284@mwanda> Cc: Andreas Dilger , Greg Kroah-Hartman , Oleg Drokin , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, Julia Lawall , kernel-janitors@vger.kernel.org, LKML From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <566E86F3.9010209@users.sourceforge.net> Date: Mon, 14 Dec 2015 10:08:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151214065325.GS5284@mwanda> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:A/6zo8vPwVAQOYj4amq4xxSx5ajxOjJlPirquT3Vljt6BOOpxfR rKSVwlDvYUdwoPeO+nO6ndMhURMfb2Ee0udaY0y4N1Bhgb6b2G0YYb7cyi4SNbzDWIVAA4y Snuv0x5vWYdVDBCBgBXKLIyODN0FhdwdK5TJCA3xO3JDCL6hqP0sEbJ0Dgl6y4GB1EDOhvX jpIyOaaSayiuJMORSbEdg== X-UI-Out-Filterresults: notjunk:1;V01:K0:q+QXsppsdA0=:2zw2YX3G6KnEVKMQIz65ko VbSWiUBGqG/5uOSS5uNp99xPoIqRO2Dp0G8YNJrmfbD2MWRwG1+7yqntSm1aFcLiunPismNl+ F0emxQGDEHBLMTf7Jp7bgAxhq3/B5rwpoo2s6cAjaldlXgvD1mOTRHzmp2t7mwwknE7LZAAKU 6xAj2WjsLHpcOj/gWyeBeXlH8KQOqOHzx8vhikyXfI7Y6OEEZFtmGPY3Ekdsw+oxlhZ8v6QEm bxdKSq0UaDxvfSW6YJexykZNk1TtC5qcYlXIUeLgjtCp+TMkTgeQVpEyqqYH4uhCOdS4uGDik oXBcBpa6ULl9cIOCJ83+ojhNOWqIEZMw3z6qHnCdIZGic2xmxbq/9UFSbrWD2vF81qCEYwvHy NgXAif1erO5tZ+lEs1Yr8IzfhBfjwalzfxr6ZQ7agPuJfw/GL6Ff+AjTFqXrg8NhW5/tyHJQJ CsJ08ygIOhiTkgnGnoqzYxE+KKwYJqvecY9RriTuBFevXfsSmJyHYoa7j+km+XKXjls0I05Iz vvMjxp+saCthxL09QHsvDW5iLajCOWaSjavkCjDbYXFUMoXVj/wc3bI8pluTaHyHatZDr4JSq I4Cs0VbDmSAXFO55lj01zVEg1pFCSeOkvhyoRfONA+nwtFswAXOzR3/flM/4fehUlxFLwetlE SnsaFryUQ7w5zBM/KSUcasuIPGr9rdoFZbcblGY3TH8jRlPRJq6tJl+H84IQqgzgIM+KU8BIf NdI/QFg5kl+XX6POGoNamujWkIaI3F5c7Il0/BKXQUfmU5uSpQf4a1cWkmLTth5t1RsGd6du/ Tcnbg9c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Markus, please stop sending these things to rename out labels unless > there is a bug. CodingStyle allows out labels. How does this feedback fit to information like the following? "… Chapter 7: … … Choose label names which say what the goto does or why the goto exists. … Avoid using GW-BASIC names … …" Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 14 Dec 2015 09:08:03 +0000 Subject: Re: [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls Message-Id: <566E86F3.9010209@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <566D7884.5050407@users.sourceforge.net> <20151214065325.GS5284@mwanda> In-Reply-To: <20151214065325.GS5284@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter Cc: Andreas Dilger , Greg Kroah-Hartman , Oleg Drokin , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, Julia Lawall , kernel-janitors@vger.kernel.org, LKML > Markus, please stop sending these things to rename out labels unless > there is a bug. CodingStyle allows out labels. How does this feedback fit to information like the following? "… Chapter 7: … … Choose label names which say what the goto does or why the goto exists. … Avoid using GW-BASIC names … …" Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 14 Dec 2015 10:08:03 +0100 Subject: [lustre-devel] [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls In-Reply-To: <20151214065325.GS5284@mwanda> References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <566D7884.5050407@users.sourceforge.net> <20151214065325.GS5284@mwanda> Message-ID: <566E86F3.9010209@users.sourceforge.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lustre-devel@lists.lustre.org > Markus, please stop sending these things to rename out labels unless > there is a bug. CodingStyle allows out labels. How does this feedback fit to information like the following? "? Chapter 7: ? ? Choose label names which say what the goto does or why the goto exists. ? Avoid using GW-BASIC names ? ?" Regards, Markus