From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Pad-0006yF-ND for qemu-devel@nongnu.org; Mon, 14 Dec 2015 04:38:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8Paa-0006lN-ED for qemu-devel@nongnu.org; Mon, 14 Dec 2015 04:38:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Paa-0006lI-94 for qemu-devel@nongnu.org; Mon, 14 Dec 2015 04:38:40 -0500 References: <1450082498-27109-1-git-send-email-a.rigo@virtualopensystems.com> <1450082498-27109-7-git-send-email-a.rigo@virtualopensystems.com> From: Paolo Bonzini Message-ID: <566E8E18.1000508@redhat.com> Date: Mon, 14 Dec 2015 10:38:32 +0100 MIME-Version: 1.0 In-Reply-To: <1450082498-27109-7-git-send-email-a.rigo@virtualopensystems.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v6 06/14] configure: Use slow-path for atomic only when the softmmu is enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alvise Rigo , qemu-devel@nongnu.org, mttcg@greensocs.com Cc: alex.bennee@linaro.org, jani.kokkonen@huawei.com, tech@virtualopensystems.com, claudio.fontana@huawei.com, rth@twiddle.net On 14/12/2015 09:41, Alvise Rigo wrote: > Use the new slow path for atomic instruction translation when the > softmmu is enabled. > > Suggested-by: Jani Kokkonen > Suggested-by: Claudio Fontana > Signed-off-by: Alvise Rigo > --- > configure | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configure b/configure > index b9552fd..cc3891a 100755 > --- a/configure > +++ b/configure > @@ -4794,6 +4794,7 @@ echo "Install blobs $blobs" > echo "KVM support $kvm" > echo "RDMA support $rdma" > echo "TCG interpreter $tcg_interpreter" > +echo "use ld/st excl $softmmu" > echo "fdt support $fdt" > echo "preadv support $preadv" > echo "fdatasync $fdatasync" > @@ -5186,6 +5187,9 @@ fi > if test "$tcg_interpreter" = "yes" ; then > echo "CONFIG_TCG_INTERPRETER=y" >> $config_host_mak > fi > +if test "$softmmu" = "yes" ; then > + echo "CONFIG_TCG_USE_LDST_EXCL=y" >> $config_host_mak > +fi Just use CONFIG_SOFTMMU in translate.c, no? A target other than ARM might need ll/sc in user-mode emulation as well. Paolo > if test "$fdatasync" = "yes" ; then > echo "CONFIG_FDATASYNC=y" >> $config_host_mak > fi >