All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Linux Virtualization <virtualization@lists.linux-foundation.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	linux-api@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per virtio-blk device
Date: Mon, 14 Dec 2015 11:31:26 +0100	[thread overview]
Message-ID: <566E9A7E.3030203__44084.7067897723$1450089108$gmane$org@redhat.com> (raw)
In-Reply-To: <CACVXFVMkV5R5GUjM7Y-U54SA-ENZZ26dbbv4K2_OYPdmmiuUqg@mail.gmail.com>



On 18/06/2014 06:04, Ming Lei wrote:
> For virtio-blk, I don't think it is always better to take more queues, and
> we need to leverage below things in host side:
> 
> - host storage top performance, generally it reaches that with more
> than 1 jobs with libaio(suppose it is N, so basically we can use N
> iothread per device in qemu to try to get top performance)
> 
> - iothreads' loading(if iothreads are at full loading, increasing
> queues doesn't help at all)
> 
> In my test, I only use the current per-dev iothread(x-dataplane)
> in qemu to handle 2 vqs' notification and precess all I/O from
> the 2 vqs, and looks it can improve IOPS by ~30%.
> 
> For virtio-scsi, the current usage doesn't make full use of blk-mq's
> advantage too because only one vq is active at the same time, so I
> guess the multi vqs' benefit won't be very much and I'd like to post
> patches to support that first, then provide test data with
> more queues(8, 16).

Hi Ming Lei,

would you like to repost these patches now that MQ support is in the kernel?

Also, I changed my mind about moving linux-aio to AioContext.  I now
think it's a good idea, because it limits the number of io_getevents
syscalls. O:-)  So I would be happy to review your patches for that as well.

Paolo

  reply	other threads:[~2015-12-14 10:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13 17:29 [RFC PATCH 0/2] block: virtio-blk: support multi vq per virtio-blk Ming Lei
2014-06-13 17:29 ` Ming Lei
2014-06-13 17:29 ` [RFC PATCH 1/2] include/uapi/linux/virtio_blk.h: introduce feature of VIRTIO_BLK_F_MQ Ming Lei
2014-06-13 17:29   ` Ming Lei
2014-06-16 12:42   ` Rusty Russell
2014-06-16 12:42   ` Rusty Russell
2014-06-16 12:42     ` Rusty Russell
2014-06-13 17:29 ` [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per virtio-blk device Ming Lei
2014-06-13 17:29   ` Ming Lei
2014-06-16 12:47   ` Rusty Russell
2014-06-16 12:47   ` Rusty Russell
2014-06-16 12:47     ` Rusty Russell
2014-06-17  2:40   ` Stefan Hajnoczi
2014-06-17  2:40     ` Stefan Hajnoczi
2014-06-17 15:50     ` Ming Lei
2014-06-17 15:50       ` Ming Lei
2014-06-17 15:53       ` Paolo Bonzini
2014-06-17 15:53         ` Paolo Bonzini
2014-06-17 16:00         ` Ming Lei
2014-06-17 16:00           ` Ming Lei
2014-06-17 16:34           ` Paolo Bonzini
2014-06-17 16:34             ` Paolo Bonzini
2014-06-18  4:04             ` Ming Lei
2014-06-18  4:04             ` Ming Lei
2014-06-18  4:04               ` Ming Lei
2015-12-14 10:31               ` Paolo Bonzini [this message]
2015-12-14 10:31               ` Paolo Bonzini
2015-12-14 10:31                 ` Paolo Bonzini
2015-12-15  1:26                 ` Ming Lei
2015-12-15  1:26                 ` Ming Lei
2015-12-15  1:26                   ` Ming Lei
2014-06-17 15:50     ` Ming Lei
2014-06-13 17:35 ` [RFC PATCH 0/2] block: virtio-blk: support multi vq per virtio-blk Jens Axboe
2014-06-13 17:35   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='566E9A7E.3030203__44084.7067897723$1450089108$gmane$org@redhat.com' \
    --to=pbonzini@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=mst@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.