From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933462AbbLONQT (ORCPT ); Tue, 15 Dec 2015 08:16:19 -0500 Received: from foss.arm.com ([217.140.101.70]:48690 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932733AbbLONQR (ORCPT ); Tue, 15 Dec 2015 08:16:17 -0500 Message-ID: <5670129B.700@arm.com> Date: Tue, 15 Dec 2015 13:16:11 +0000 From: Vladimir Murzin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Rob Herring CC: Arnd Bergmann , Russell King - ARM Linux , Greg Kroah-Hartman , Daniel Lezcano , Thomas Gleixner , =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Maxime Coquelin , Mark Rutland , Pawel Moll , Ian Campbell , Kumar Gala , Jiri Slaby , "devicetree@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-api@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver References: <1449048790-25859-1-git-send-email-vladimir.murzin@arm.com> <1449048790-25859-3-git-send-email-vladimir.murzin@arm.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/12/15 13:56, Rob Herring wrote: > On Wed, Dec 2, 2015 at 3:33 AM, Vladimir Murzin wrote: >> MPS2 platform has simple 32 bits general purpose countdown timers. >> >> The driver uses the first detected timer as a clocksource and the rest >> of the timers as a clockevent >> >> Signed-off-by: Vladimir Murzin >> --- >> drivers/clocksource/Kconfig | 5 + >> drivers/clocksource/Makefile | 1 + >> drivers/clocksource/mps2-timer.c | 277 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 283 insertions(+) >> create mode 100644 drivers/clocksource/mps2-timer.c >> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index 2eb5f0e..8bca09c 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -137,6 +137,11 @@ config CLKSRC_STM32 >> depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST) >> select CLKSRC_MMIO >> >> +config CLKSRC_MPS2 >> + bool "Clocksource for MPS2 SoCs" if COMPILE_TEST >> + depends on OF && ARM > > Does this really depend on both of these for COMPILE_TEST? Not really... > > You need to select CLKSRC_OF rather than CLKSRC_MMIO as well. > Does it looks better? config CLKSRC_MPS2 bool "Clocksource for MPS2 SoCs" if COMPILE_TEST depends on GENERIC_SCHED_CLOCK select CLKSRC_MMIO select CLKSRC_OF Cheers Vladimir > Rob > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Murzin Subject: Re: [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver Date: Tue, 15 Dec 2015 13:16:11 +0000 Message-ID: <5670129B.700@arm.com> References: <1449048790-25859-1-git-send-email-vladimir.murzin@arm.com> <1449048790-25859-3-git-send-email-vladimir.murzin@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Arnd Bergmann , Russell King - ARM Linux , Greg Kroah-Hartman , Daniel Lezcano , Thomas Gleixner , =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Maxime Coquelin , Mark Rutland , Pawel Moll , Ian Campbell , Kumar Gala , Jiri Slaby , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 14/12/15 13:56, Rob Herring wrote: > On Wed, Dec 2, 2015 at 3:33 AM, Vladimir Murzin wrote: >> MPS2 platform has simple 32 bits general purpose countdown timers. >> >> The driver uses the first detected timer as a clocksource and the rest >> of the timers as a clockevent >> >> Signed-off-by: Vladimir Murzin >> --- >> drivers/clocksource/Kconfig | 5 + >> drivers/clocksource/Makefile | 1 + >> drivers/clocksource/mps2-timer.c | 277 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 283 insertions(+) >> create mode 100644 drivers/clocksource/mps2-timer.c >> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index 2eb5f0e..8bca09c 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -137,6 +137,11 @@ config CLKSRC_STM32 >> depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST) >> select CLKSRC_MMIO >> >> +config CLKSRC_MPS2 >> + bool "Clocksource for MPS2 SoCs" if COMPILE_TEST >> + depends on OF && ARM > > Does this really depend on both of these for COMPILE_TEST? Not really... > > You need to select CLKSRC_OF rather than CLKSRC_MMIO as well. > Does it looks better? config CLKSRC_MPS2 bool "Clocksource for MPS2 SoCs" if COMPILE_TEST depends on GENERIC_SCHED_CLOCK select CLKSRC_MMIO select CLKSRC_OF Cheers Vladimir > Rob > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: vladimir.murzin@arm.com (Vladimir Murzin) Date: Tue, 15 Dec 2015 13:16:11 +0000 Subject: [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver In-Reply-To: References: <1449048790-25859-1-git-send-email-vladimir.murzin@arm.com> <1449048790-25859-3-git-send-email-vladimir.murzin@arm.com> Message-ID: <5670129B.700@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 14/12/15 13:56, Rob Herring wrote: > On Wed, Dec 2, 2015 at 3:33 AM, Vladimir Murzin wrote: >> MPS2 platform has simple 32 bits general purpose countdown timers. >> >> The driver uses the first detected timer as a clocksource and the rest >> of the timers as a clockevent >> >> Signed-off-by: Vladimir Murzin >> --- >> drivers/clocksource/Kconfig | 5 + >> drivers/clocksource/Makefile | 1 + >> drivers/clocksource/mps2-timer.c | 277 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 283 insertions(+) >> create mode 100644 drivers/clocksource/mps2-timer.c >> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index 2eb5f0e..8bca09c 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -137,6 +137,11 @@ config CLKSRC_STM32 >> depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST) >> select CLKSRC_MMIO >> >> +config CLKSRC_MPS2 >> + bool "Clocksource for MPS2 SoCs" if COMPILE_TEST >> + depends on OF && ARM > > Does this really depend on both of these for COMPILE_TEST? Not really... > > You need to select CLKSRC_OF rather than CLKSRC_MMIO as well. > Does it looks better? config CLKSRC_MPS2 bool "Clocksource for MPS2 SoCs" if COMPILE_TEST depends on GENERIC_SCHED_CLOCK select CLKSRC_MMIO select CLKSRC_OF Cheers Vladimir > Rob > > >