From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8sUP-0007ml-Ce for qemu-devel@nongnu.org; Tue, 15 Dec 2015 11:30:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8sUL-0006k8-2Z for qemu-devel@nongnu.org; Tue, 15 Dec 2015 11:30:13 -0500 References: <1449531275-30362-1-git-send-email-jsnow@redhat.com> <1449531275-30362-5-git-send-email-jsnow@redhat.com> <56661C9D.8020800@redhat.com> <566F20F3.5060103@redhat.com> From: Eric Blake Message-ID: <56703FFE.5080007@redhat.com> Date: Tue, 15 Dec 2015 09:29:50 -0700 MIME-Version: 1.0 In-Reply-To: <566F20F3.5060103@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CiD5L33sMDk6BloDet16FB8TxX2JOqpoE" Subject: Re: [Qemu-devel] [PATCH for-2.6 v2 04/10] fdc: add default drive type option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CiD5L33sMDk6BloDet16FB8TxX2JOqpoE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/14/2015 01:05 PM, John Snow wrote: > I was actually contemplating re-spinning this for a v3: >=20 > Instead of having a "typeA" and "typeB" properties of the FDC, I'll jus= t > spin the properties in such a way that they write directly to > FDCtrl.drives[n].drive, which avoids the need for two new members and a= > method designed to "fetch" the default from the controller. >=20 > I also want to add a "fallback" member to the FDC as a CLI configurable= > parameter such that when using "auto" you can configure directly what > type of drive you'll get. >=20 > This way the default behavior will be "auto" (but configurable) and the= > fallback if the drive is empty or it cannot make a confident guess will= > be whatever the user chose as "fallback" -- presumed "144" before this > series and "288" afterwards. >=20 > I believe this also opens up the possibility for having "fallback" > default to "144" for machine types created prior to 2.6 ... I think. > (I'm less familiar with machine compat code as of yet.) >=20 > Sound reasonable? On paper, yes that sounds reasonable. I'm also not familiar enough with machine types to know if it will let you keep 2.5 and earlier machines with a fallback of 144, and newer machines with a fallback of 288, but sounds promising. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CiD5L33sMDk6BloDet16FB8TxX2JOqpoE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcD/+AAoJEKeha0olJ0NqLYUH/3zwoB+iQqTMwqcOG6K0fms1 KFwejsRjLwC8xOkWY6EeYHf83e3MZd3Oo25BqRL/yp/C/K4dHDUuEqD9qS++CXmt l5OB3mVmcaEshVXmS3jEV12kd0vMBrWhVqTG027qaYCSs+CRgizmlH5kK9powpmB hvLGDBTLtJyzNHGpllo2XAzkcKzoxlqKp5z1GaZCSJoNhNjCOMCprABVcwwtAK1+ MAktWqDnDr67VU9CrYkf8PeQgWugC4Fp0ESTLLRha6MkgfryrwXsypXvCUZEL8cn haJWvw65rxsYL0zatOLMW1oR+j6ZapM/rK0aWjghvK0QQDQpbMWvAiY8FMMrxwo= =3d7q -----END PGP SIGNATURE----- --CiD5L33sMDk6BloDet16FB8TxX2JOqpoE--