From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965496AbbLOSuE (ORCPT ); Tue, 15 Dec 2015 13:50:04 -0500 Received: from mout.web.de ([212.227.15.14]:49392 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965156AbbLOSuB (ORCPT ); Tue, 15 Dec 2015 13:50:01 -0500 Subject: Re: staging: lustre: Delete unnecessary goto statements in six functions To: Joe Perches References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <566D7830.9060000@users.sourceforge.net> <1450189676.3551.1.camel@perches.com> <20151215144133.GC5284@mwanda> <1450191751.3551.14.camel@perches.com> <20151215174844.GE5284@mwanda> <1450203011.4142.4.camel@perches.com> <56705B71.6090307@users.sourceforge.net> <1450204451.4142.19.camel@perches.com> Cc: Dan Carpenter , Andreas Dilger , Greg Kroah-Hartman , Oleg Drokin , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <567060C3.5070608@users.sourceforge.net> Date: Tue, 15 Dec 2015 19:49:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450204451.4142.19.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:xjEEVZ29Y8tApDyRa3VIi5Ixodlp47CdHGMnHYh1hBqRisCYgxU 7sYONuAgyC6vv0bQMrenA3kndfu6+6UzRp6KCaLdHvW5l0/zAPgGXpXkYTNU7fE2YE3UHNK fMiXfzgmMgGguHCEeOf9BfbgMHAYViCaWzCohn+tT6PoLF9CDu5jhsn7LzPfIgEFg3db7sA u7+z2pbqzCtpezvJL8Z/Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:bqcFBU/41rk=:B/RwbxL7lbrbhpiiHJl7Ns H4Z6xf8EhJPMioaQ1vUUFRVQsYwbP1Fo9+2E/OhBDRyB6qj3FxpgG5dJzDyADKeK6h/e66be7 h//TJxDOFHYBJtCFfSh8+KhC0nsH+fzVSBv8csopADB8RNDP2/7DGmspGVkkeH4L3X9LRyzL2 AmQfp/9dcc6ww8GQQunUj31n9wd4xsz9Y0HOlS90zs12y1WzeBztt/LJ2Gd+nSlWTCXPLJtY+ up19Wr6LdpL1V+EI5yOOl2pHP7WlXkauXi5JucJtr4HJYhIDTa78rSlefsklw+65BZIv1i/WD KHnIu5kzdHoLUlS9VcufFrxQtugobeypwcREAcTTHP5OA1l6fdCGWQJ4xoc0yxmNK1sHDLoL6 iOcJkvNMxT2FYi9CexOogfkHQSMF2qM3pLEQLHIgwAA3N6hUvlOp2LL7as2qsVF+fHDorMkvW 5tkTkFigVMeAKEpkH6LKEamrU9pLUeTAmLTZkWGgFUUSAq8OIj2mc+yt/HB1X0Sz+zy2kTrPK MZT7zdmkXqJdFdTroLnTyMP2QZOAr7mZZLIUP5kZw2R2CpYkhUgu+HsNDaNE3JrSn967ZqwwI psAWDaiAIpggfmxDp3nA94liL35qPWsKD2unq2Khv0t4vrq7RoHeDTjVFgJmMfo2a4bpl158t Cg6AIUJSTwVFB+EJLobnfO1kkgT1bTw2TllwZMdgapE0WdCLF3D+UoYEICBqCjiERINPR5UYg EPGa5HvMcb33MzrCbu5oSzZZPelduD71KLokblOLrRk+Yojr3lQ9nG9cA4JJ6smn8rRKweU4g 0wLSC9K Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I think there should _not_ be a hardened rule. I guess that it can become hard to achieve consensus on a precise rule. > Style is just a guide. Generally nice … > Do what you think appropriate. I'm sorry for my evolving understanding. - But I imagine that your feedback can cause further software development troubles if the acceptance for this update suggestion will really depend on the number of blank lines before a jump label. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 15 Dec 2015 18:49:39 +0000 Subject: Re: staging: lustre: Delete unnecessary goto statements in six functions Message-Id: <567060C3.5070608@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <566D7830.9060000@users.sourceforge.net> <1450189676.3551.1.camel@perches.com> <20151215144133.GC5284@mwanda> <1450191751.3551.14.camel@perches.com> <20151215174844.GE5284@mwanda> <1450203011.4142.4.camel@perches.com> <56705B71.6090307@users.sourceforge.net> <1450204451.4142.19.camel@perches.com> In-Reply-To: <1450204451.4142.19.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Joe Perches Cc: Dan Carpenter , Andreas Dilger , Greg Kroah-Hartman , Oleg Drokin , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall > I think there should _not_ be a hardened rule. I guess that it can become hard to achieve consensus on a precise rule. > Style is just a guide. Generally nice =85 > Do what you think appropriate. I'm sorry for my evolving understanding. - But I imagine that your feedback can cause further software development troubles if the acceptance for this update suggestion will really depend on the number of blank lines before a jump label. Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 15 Dec 2015 19:49:39 +0100 Subject: [lustre-devel] staging: lustre: Delete unnecessary goto statements in six functions In-Reply-To: <1450204451.4142.19.camel@perches.com> References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <566D7830.9060000@users.sourceforge.net> <1450189676.3551.1.camel@perches.com> <20151215144133.GC5284@mwanda> <1450191751.3551.14.camel@perches.com> <20151215174844.GE5284@mwanda> <1450203011.4142.4.camel@perches.com> <56705B71.6090307@users.sourceforge.net> <1450204451.4142.19.camel@perches.com> Message-ID: <567060C3.5070608@users.sourceforge.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lustre-devel@lists.lustre.org > I think there should _not_ be a hardened rule. I guess that it can become hard to achieve consensus on a precise rule. > Style is just a guide. Generally nice ? > Do what you think appropriate. I'm sorry for my evolving understanding. - But I imagine that your feedback can cause further software development troubles if the acceptance for this update suggestion will really depend on the number of blank lines before a jump label. Regards, Markus