From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH 11/11] tty: serial: 8250: Delete commented code Date: Wed, 16 Dec 2015 09:05:26 -0800 Message-ID: <567199D6.4050106@hurleysoftware.com> References: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de> <1450280177-4460-12-git-send-email-anton.wuerfel@fau.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Greg Kroah-Hartman , Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Heikki Krogerus , Andy Shevchenko , Qipeng Zha , Desmond Liu , Wang Long , Matt Redfearn , Paul Burton , Ralf Baechle , Krzysztof Kozlowski , Peter Hung , Soeren Grunewald , Adam Lee , "Maciej S. Szmigiero" , Mans Rullgard , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de, Phillip Raffeck To: Anton Wuerfel , linux-serial@vger.kernel.org Return-path: In-Reply-To: <1450280177-4460-12-git-send-email-anton.wuerfel@fau.de> List-ID: List-Id: linux-parisc.vger.kernel.org Hi Anton, On 12/16/2015 07:36 AM, Anton Wuerfel wrote: > This patch removes code which has been commented out. It serves no > documentary purposes and decreases the readability of the remaining c= ode. > Furthermore the comment style causes checkpatch warnings. If this cod= e > should ever be needed again, git keeps track of it. This is bad idea. I can count on one hand the number of times I've tried to find deleted code in git. How would you go about finding all deleted sub-vendor ids in the 16.5M-line Linux source tree, say since 2.6.32? Regards, Peter Hurley > Signed-off-by: Anton W=C3=BCrfel > Signed-off-by: Phillip Raffeck > CC: linux-kernel@i4.cs.fau.de > --- > drivers/tty/serial/8250/8250_pci.c | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/= 8250/8250_pci.c > index 3bc0303..9136f0f 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -4928,16 +4928,9 @@ static struct pci_device_id serial_pci_tbl[] =3D= { > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > 0x1208, 0x0004, 0, 0, > pbn_b0_4_921600 }, > -/* { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > - 0x1402, 0x0002, 0, 0, > - pbn_b0_2_921600 }, */ > -/* { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > - 0x1404, 0x0004, 0, 0, > - pbn_b0_4_921600 }, */ > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF1, > 0x1208, 0x0004, 0, 0, > pbn_b0_4_921600 }, > - > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF2, > 0x1204, 0x0004, 0, 0, > pbn_b0_4_921600 }, >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-parisc"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934302AbbLPRFc (ORCPT ); Wed, 16 Dec 2015 12:05:32 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:33408 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934226AbbLPRFa (ORCPT ); Wed, 16 Dec 2015 12:05:30 -0500 Subject: Re: [PATCH 11/11] tty: serial: 8250: Delete commented code To: Anton Wuerfel , linux-serial@vger.kernel.org References: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de> <1450280177-4460-12-git-send-email-anton.wuerfel@fau.de> Cc: Greg Kroah-Hartman , Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Heikki Krogerus , Andy Shevchenko , Qipeng Zha , Desmond Liu , Wang Long , Matt Redfearn , Paul Burton , Ralf Baechle , Krzysztof Kozlowski , Peter Hung , Soeren Grunewald , Adam Lee , "Maciej S. Szmigiero" , Mans Rullgard , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de, Phillip Raffeck From: Peter Hurley Message-ID: <567199D6.4050106@hurleysoftware.com> Date: Wed, 16 Dec 2015 09:05:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450280177-4460-12-git-send-email-anton.wuerfel@fau.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anton, On 12/16/2015 07:36 AM, Anton Wuerfel wrote: > This patch removes code which has been commented out. It serves no > documentary purposes and decreases the readability of the remaining code. > Furthermore the comment style causes checkpatch warnings. If this code > should ever be needed again, git keeps track of it. This is bad idea. I can count on one hand the number of times I've tried to find deleted code in git. How would you go about finding all deleted sub-vendor ids in the 16.5M-line Linux source tree, say since 2.6.32? Regards, Peter Hurley > Signed-off-by: Anton Würfel > Signed-off-by: Phillip Raffeck > CC: linux-kernel@i4.cs.fau.de > --- > drivers/tty/serial/8250/8250_pci.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c > index 3bc0303..9136f0f 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -4928,16 +4928,9 @@ static struct pci_device_id serial_pci_tbl[] = { > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > 0x1208, 0x0004, 0, 0, > pbn_b0_4_921600 }, > -/* { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > - 0x1402, 0x0002, 0, 0, > - pbn_b0_2_921600 }, */ > -/* { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > - 0x1404, 0x0004, 0, 0, > - pbn_b0_4_921600 }, */ > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF1, > 0x1208, 0x0004, 0, 0, > pbn_b0_4_921600 }, > - > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF2, > 0x1204, 0x0004, 0, 0, > pbn_b0_4_921600 }, > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH 11/11] tty: serial: 8250: Delete commented code Date: Wed, 16 Dec 2015 09:05:26 -0800 Message-ID: <567199D6.4050106@hurleysoftware.com> References: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de> <1450280177-4460-12-git-send-email-anton.wuerfel@fau.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1450280177-4460-12-git-send-email-anton.wuerfel@fau.de> Sender: linux-parisc-owner@vger.kernel.org To: Anton Wuerfel , linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Heikki Krogerus , Andy Shevchenko , Qipeng Zha , Desmond Liu , Wang Long , Matt Redfearn , Paul Burton , Ralf Baechle , Krzysztof Kozlowski , Peter Hung , Soeren Grunewald , Adam Lee , "Maciej S. Szmigiero" , Mans Rullgard , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de, Phillip Raffeck List-Id: linux-serial@vger.kernel.org Hi Anton, On 12/16/2015 07:36 AM, Anton Wuerfel wrote: > This patch removes code which has been commented out. It serves no > documentary purposes and decreases the readability of the remaining c= ode. > Furthermore the comment style causes checkpatch warnings. If this cod= e > should ever be needed again, git keeps track of it. This is bad idea. I can count on one hand the number of times I've tried to find deleted code in git. How would you go about finding all deleted sub-vendor ids in the 16.5M-line Linux source tree, say since 2.6.32? Regards, Peter Hurley > Signed-off-by: Anton W=C3=BCrfel > Signed-off-by: Phillip Raffeck > CC: linux-kernel@i4.cs.fau.de > --- > drivers/tty/serial/8250/8250_pci.c | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/= 8250/8250_pci.c > index 3bc0303..9136f0f 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -4928,16 +4928,9 @@ static struct pci_device_id serial_pci_tbl[] =3D= { > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > 0x1208, 0x0004, 0, 0, > pbn_b0_4_921600 }, > -/* { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > - 0x1402, 0x0002, 0, 0, > - pbn_b0_2_921600 }, */ > -/* { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > - 0x1404, 0x0004, 0, 0, > - pbn_b0_4_921600 }, */ > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF1, > 0x1208, 0x0004, 0, 0, > pbn_b0_4_921600 }, > - > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF2, > 0x1204, 0x0004, 0, 0, > pbn_b0_4_921600 }, >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-parisc"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html