From: Paolo Bonzini <pbonzini@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, crosthwaitepeter@gmail.com
Subject: Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices
Date: Thu, 17 Dec 2015 00:24:17 +0100 [thread overview]
Message-ID: <5671F2A1.6060005@redhat.com> (raw)
In-Reply-To: <0209faa3788f57deeb3ce4a197019b095bc2c05f.1450300479.git.alistair.francis@xilinx.com>
On 16/12/2015 22:45, Alistair Francis wrote:
> +
> + /* Rename each SPI bus after the SPI device to allow the board
> + * to access all of the busses from the SoC.
> + */
> + spi_bus = qdev_get_child_bus(DEVICE(&s->spi[i]), "spi0");
> + snprintf(bus_name, 6, "spi%d", i);
> + qdev_bus_rename(spi_bus, bus_name);
> +
> + /* Add the SPI buses to the SoC child bus */
> + /* FIXME: This causes the later buses to be duplicated in
> + * the SPI devices printout when running qtre.
> + */
> + QLIST_INSERT_HEAD(&dev->child_bus, spi_bus, sibling);
Isn't the SPI bus accessible with something similar to spi[0-5]/spi0,
even without this hack?
In any case, I would prefer qdev_bus_rename to stay in xlnx-zynqmp.c.
Paolo
next prev parent reply other threads:[~2015-12-16 23:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 21:44 [Qemu-devel] [PATCH v5 0/6] Connect the SPI devices to ZynqMP Alistair Francis
2015-12-16 21:45 ` [Qemu-devel] [PATCH v5 1/6] m25p80.c: Add sst25wf080 SPI flash device Alistair Francis
2015-12-16 21:45 ` [Qemu-devel] [PATCH v5 2/6] ssi: Move ssi.h into a separate directory Alistair Francis
2015-12-16 21:45 ` [Qemu-devel] [PATCH v5 3/6] xilinx_spips: Separate the state struct into a header Alistair Francis
2015-12-19 22:06 ` Peter Crosthwaite
2015-12-16 21:45 ` [Qemu-devel] [PATCH v5 4/6] qdev: Add a function to rename busses Alistair Francis
2015-12-16 22:36 ` Peter Crosthwaite
2015-12-17 0:55 ` Alistair Francis
2015-12-16 21:45 ` [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices Alistair Francis
2015-12-16 23:24 ` Paolo Bonzini [this message]
2015-12-17 0:45 ` Alistair Francis
2015-12-17 8:26 ` Peter Maydell
2015-12-17 10:28 ` Paolo Bonzini
2015-12-17 11:11 ` Peter Maydell
2015-12-17 11:12 ` Paolo Bonzini
2015-12-18 17:17 ` Alistair Francis
2015-12-18 17:55 ` Paolo Bonzini
2015-12-19 21:59 ` Peter Crosthwaite
2015-12-16 21:45 ` [Qemu-devel] [PATCH v5 6/6] xlnx-ep108: Connect the SPI Flash Alistair Francis
2015-12-19 22:09 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5671F2A1.6060005@redhat.com \
--to=pbonzini@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=crosthwaitepeter@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.