From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulanit Subject: Re: [PATCH v2] i2c: designware: Do not require clock when SSCN and FFCN are provided Date: Wed, 16 Dec 2015 21:01:53 -0600 Message-ID: <567225A1.7020001@amd.com> References: <1450319025-19120-1-git-send-email-Suravee.Suthikulpanit@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bn1bon0076.outbound.protection.outlook.com ([157.56.111.76]:21870 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756074AbbLQDCF (ORCPT ); Wed, 16 Dec 2015 22:02:05 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Loc Ho Cc: Mika Westerberg , wsa@the-dreams.de, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, Ken Xue , linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, Linux Kernel Mailing List On 12/16/2015 8:56 PM, Loc Ho wrote: > Hi, > >> The current driver uses input clock source frequency to calculate >> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not >> currently have a good way to provide the frequency information. >> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used >> to directly provide these values. So, the clock information should >> no longer be required during probing. >> >> However, since clk can be invalid, additional checks must be done where >> we are making use of it. >> >> Signed-off-by: Suravee Suthikulpanit >> --- >> >> Note: This has been tested on AMD Seattle RevB for both DT and ACPI. > > Tested on X-Gene hardware also. > > -Loc > Thanks for quick response. Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756130AbbLQDCH (ORCPT ); Wed, 16 Dec 2015 22:02:07 -0500 Received: from mail-bn1bon0076.outbound.protection.outlook.com ([157.56.111.76]:21870 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756074AbbLQDCF (ORCPT ); Wed, 16 Dec 2015 22:02:05 -0500 X-Greylist: delayed 130175 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Dec 2015 22:02:04 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v2] i2c: designware: Do not require clock when SSCN and FFCN are provided To: Loc Ho References: <1450319025-19120-1-git-send-email-Suravee.Suthikulpanit@amd.com> CC: Mika Westerberg , , , , Ken Xue , , , Linux Kernel Mailing List From: Suravee Suthikulanit Message-ID: <567225A1.7020001@amd.com> Date: Wed, 16 Dec 2015 21:01:53 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BLUPR01CA051.prod.exchangelabs.com (25.160.23.41) To BY1PR12MB0438.namprd12.prod.outlook.com (25.162.147.14) X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;2:WbqzKZkNLb2wNWctn6nJySLM5azNvi0DfOaD3FPmh+lUJRbsituAvLPM4NRB5NzFSqwYatvQzNal6VxEWEvTEbdEMZ0uIupRWZBq8ZQ2K1h67zdol71W/O8ta7MWKJJ9Pc6IVUBtihDDviNx6/eD4g==;3:6HSyXJSQrxBn5gVDjKa/4+gnu+j3oDNGOdSN5ubpluH2IRja82ZA3LlgMvcjlaO6xjVIDhTeZxjc9NTR7J0HQ8EH1fbJqY2XjWSKXzLgtWbo6A00e0n1bdpoA0yHL4iO;25:aeqt0E0rJuy10IZiPiYJumItfsmajeIl/YzN1tCGAFmzUJ3qo0ppx2c1qIy6q8YQtSm6rcVNAwte9nGjs4cKmANtIDIrrCOD5e1xhuaj1l9k1sMxypEjDeU0OUQu7QbZMlbe6jtEkBDkBqKsJdKMUhXiekwJTEb7vHJZaA+hvVhHMRyroNuCcNmnu6qcBZhsiSnO4vHhI+I9OQVHZqS+FKMjTG6p3cFlhC0UXzDxa8YWayh0wMzA4UEhB22yrYuH X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0438; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;20:RSS6s7jRTwvXH5J0FqgUw82IqNx4lYZAoahILXNuB4mEc9yvYFMycSsK54nv6LHGYyOeDTaLIj1rRF5pPXk5OvtR8m5j8t3EWmb+VRd93iHSnFRUuHEHvXltVvzVperfrHLz1pXj/mBY2xUioBXUlha9cKzyiPOH0LoMWTU+/1QL64uS7TpRutB4Yt/BRNckJTgSQHQh0kWgzix3XFcfVknogy03yQLpdmSduDdl+bgyObP34Tlxdn1Oi875wn9oIndGX1ZSeB9KRzW8h+bEPt3ag7euT8MI5rpKeB3o7ZpWeQkSdN3g7w6KLia8iaj8hGeQSrt6YQBYe7FQmSVv6lSpV0wZ93rWDBGxQ+vbi4DVewQgZrp8w7EeA6nthu0OATYOd9eOONPUpa1anOEEIfazOfnGHjuy3bVGLZJGgliBl/GRDoigANkZu1DpApVT+ni1ib0V4Dt39+kIs/u3Nm4xDbXbrvozMenMheCXnKSG1QYo9vzajgTt3zWETcVU;4:aHDho0CxTv7lUroKfSae/Jj2De1SAdNxpmsATv0M8UrNBB8Z0bLmNHsRJfsVt2Ms2eS+tgbvakFoW5IXYhlhmPLt9MVhaLT95oPXq6Su1w4uueWrPSXnp86aVCzz+WvhdbP/zXaIGb2qeQjwR094Nn5pMGiK8NBPrkP2N6vx9zgaShPCm1hbira/QyZo3TpQXs24sJmoPIUejkidV9MLDnrUiF0vj/YD/omH3rGADXWSeCLmhOUYlSGoS70/TBGnT6JO21ZgAi35VNBWfD42d9R8oqGFHD1IeYGAkQ9lttKlPr6YpBYZUYRtBhqpHQaslsWJbyC64cZVoGTlKaliHIZlNlyVFW00Atx8R8XD0RO5ZmHtdaBQKWlyU+vwwauVxfiPwaVdZ36gAgP+dyK8MQ5DTvpMdJmejXo+9CKj/V0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046);SRVR:BY1PR12MB0438;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0438; X-Forefront-PRVS: 07935ACF08 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(24454002)(479174004)(199003)(189002)(377454003)(65816999)(105586002)(106356001)(6116002)(3846002)(230700001)(1096002)(586003)(5004730100002)(50466002)(101416001)(36756003)(83506001)(122386002)(40100003)(42186005)(59896002)(33656002)(4001350100001)(50986999)(81156007)(76176999)(87266999)(99136001)(97736004)(65806001)(47776003)(66066001)(87976001)(189998001)(54356999)(110136002)(80316001)(19580395003)(86362001)(19580405001)(5001960100002)(65956001)(77096005)(2950100001)(5008740100001)(92566002)(23676002)(64126003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0438;H:[10.236.18.83];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjEyTUIwNDM4OzIzOktzYWZBSTdsdjJJOUVubkFwWlVIcmJZMWtF?= =?utf-8?B?MTI0a2lUZVlubWNtMGlpODczU29qUUV0VFZqTENzbnd2VG5paWJ2Uzh0M1Mz?= =?utf-8?B?bXVoTUZRcnJhYTNZN2EvNEwxOURmVi8xZHZHS1ZoUnJtVmdUZ2E0dWl4aGwv?= =?utf-8?B?c0JESkw2a0MyOUE1dEdKK204MDBLL1FQVlZZMmdJWHZ4SXd0a2JpeFBNMkxp?= =?utf-8?B?K0I4bThZc3dDMzJqOG5ZWWNiR0tpMTdFdklzbjNlL25vVlJ4ejJrbnFaazVL?= =?utf-8?B?UGZnWitvOWlpTk0yRTZoUXU5ZDdNYXBTczRyMEwwRUFKV3VEME4zV2ZQV0Zk?= =?utf-8?B?N1NaTDd1REJhelZGZTB4ZW51VWlOQ3p4cFZNTFRYWXpyTjU3Q0ZhcVFLSitn?= =?utf-8?B?Y2pnTUVFNUFabWlleisrQUM2ZUI1VVVPelFtSkhUWGdzamRPSStSMFZmSFZD?= =?utf-8?B?emhSZEhmdStPMUFEY25ORGhhUm1ZaU9yd3JmUDN3a0JUalNYaS9NUFczYmhR?= =?utf-8?B?clV6Y0ZkL3BLVVJhRndlOHhyRG5BQ0ZybnE1RmEwSTlocVBIdndVV1UrenNG?= =?utf-8?B?cldDOXFSS1FGZ1h4UWtLZk5waHcvaXJiNkxXdm5JME1GRE15eHJPd0NVSGpR?= =?utf-8?B?NkRrbFk5N1JxcWlOWHJNaUdRczl3eHg5bHEyT0Z0ZHVLNDMwOFUzdHR6dG1M?= =?utf-8?B?QUM1NG9jeUpMcFBtSThjcENkMHFBS2JQSGJ0UFphT2ZkREVaMVZZOWxQWHZD?= =?utf-8?B?TDFXSVM5eWI2d3FNbFF5UFVYK3BaY2NBWExGeVNnTnlGcUhSTTNWTVhkeHhv?= =?utf-8?B?WllwSU80S2RveHJ0SlA5aVJpWGM5NXNXUitqckhSSDRFOTVXVi9rbGNoaXZG?= =?utf-8?B?VG85WkZQbGdXTU9RR3BmV2FIczJneDFweW41NTZmLzN5UmRmdjFhOVBJa1Bi?= =?utf-8?B?Z2NJYk9MVHhxRzU4QXdoeFlSRVA1YkpKaTJoejdkRTRpMUlZajJZYlBDN2ZT?= =?utf-8?B?QU0wUW5EZU85RDc1S0ZEWlljeFpzZmtYMUs3UkwrS3VuaG44MzhpZjlpQjNZ?= =?utf-8?B?enIybFRhbkhPaldaQWNQbUFTSnFJcXo3R05LaFI1YTdsMmxESTVtcWRBRWlq?= =?utf-8?B?REwyelhVZVpPRVVSY0FGR2p4ZVZ5RysvcUlXR0JqNUtITjEzYkFoMllhTVVn?= =?utf-8?B?YTZJYjRYK25KT2JjeFFzRkFpNEtmSklDblp6QjdpQ2k4dmRJZDcwMzg2ZXVS?= =?utf-8?B?UE5hckJVVHdLMENneFJEQ2h0Ni9xM3JMSkJaTGJCdXRURzloR1NDcEVDbnpk?= =?utf-8?B?V3pqUlQwdUJJNTUxeE00aHFjWGxUdEY5RkhPQ01EUU51QUJSS0NWYmJTRG55?= =?utf-8?B?QTZHMEhTUnhWazdlM2pRcnpoUlhKYXhUQlQ5aW5DNVdSeWlaeTkwYTl3UE1a?= =?utf-8?B?ZzRpS1o1bVlwMXh5VjlZUU5zS3NUK3d1dDFhY1VpRWlTKzU3SDhYR2JBY0cv?= =?utf-8?B?WThWTWhub2JXUUxteTlRTm10R0pFbHd5ZTBENjYxZUZxV3FRMHNuUHZwdW0z?= =?utf-8?B?NmJONExxSmtBV1VwazlncEVWK3VXNzlLMUtqcnlRZ2d4K0lrLzQva0pwbE12?= =?utf-8?B?RTVhU1JiRVFJVWUyY05IVXhjVk5KZkZVbVdqWWhYVzc0UGhSaTVWY3VwejdC?= =?utf-8?B?ODBEY2g5elkxWkJKT1oxSWduNkxzNDhPNnBiNVd3ZnJCTzVQakdNanhvbjZX?= =?utf-8?Q?FO24xZDIYlgTG18xuoU5XVfb5WqP87q/WNzD4=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0438;5:6y3NtyhaFoBO6Z+fCfONe90foaplrLQspJkwrwj7kW1KymLmwZnB9zNvFTn1mAE1SXOjjw1Ldd7NQRb4oXZ97j/B53sirWYFtnR9VGVV+ooxcOSXNJ+brC/zj37iUtem7afWfFY2868vaUwfDXbBaQ==;24:0caE0ukKn19GnwPqY6t5FFTakdYmglfM9pti7CY/xRKZsvCSrgP2V6Cg4PWHd+WFWjcZCJbguDOgwSbeCTyeb/SicmYQcNlORRF0ZJtP15A=;20:rxdQEFOKWi0jefUPSjeOOp2sfZnCw30rKDmcCirULMjIsjZFq9v25MUk75PcyerYeoMlXVugeiW8O6gSUeWOg+oq5XVUsBsTNx0Ss1phKfkJCaRpfTMH1ZZ1ZxXhulXy5vvHuo/O+5sLnj8De98APkmLLOvpy8dF4N68Bo6DEXCSRiZDYlpsfmjvmggpLgtlSDiJomf40Qb/APE8gZJBJ9JMDYmkNimTkjds+aLBlv6f4/3sHD9BDHbitjaEB0/Z X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2015 03:02:00.0678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0438 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/16/2015 8:56 PM, Loc Ho wrote: > Hi, > >> The current driver uses input clock source frequency to calculate >> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not >> currently have a good way to provide the frequency information. >> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used >> to directly provide these values. So, the clock information should >> no longer be required during probing. >> >> However, since clk can be invalid, additional checks must be done where >> we are making use of it. >> >> Signed-off-by: Suravee Suthikulpanit >> --- >> >> Note: This has been tested on AMD Seattle RevB for both DT and ACPI. > > Tested on X-Gene hardware also. > > -Loc > Thanks for quick response. Suravee