From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50306)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1a9V3I-0001S1-4J
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 04:40:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1a9V3D-0004xn-VI
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 04:40:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53501)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1a9V3D-0004w6-Oo
	for qemu-devel@nongnu.org; Thu, 17 Dec 2015 04:40:43 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (Postfix) with ESMTPS id 487CDC0B7E2A
	for <qemu-devel@nongnu.org>; Thu, 17 Dec 2015 09:40:42 +0000 (UTC)
References: <1449859353-1574-1-git-send-email-ehabkost@redhat.com>
	<1449859353-1574-12-git-send-email-ehabkost@redhat.com>
	<56702367.4050800@redhat.com>
	<20151216194809.GO3774@thinpad.lan.raisama.net>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <56728317.3000808@redhat.com>
Date: Thu, 17 Dec 2015 11:40:39 +0200
MIME-Version: 1.0
In-Reply-To: <20151216194809.GO3774@thinpad.lan.raisama.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 11/14] pc: Remove
	PcGuestInfo.isapc_ram_fw field
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On 12/16/2015 09:48 PM, Eduardo Habkost wrote:
> On Tue, Dec 15, 2015 at 04:27:51PM +0200, Marcel Apfelbaum wrote:
>> On 12/11/2015 08:42 PM, Eduardo Habkost wrote:
> [...]
>>> @@ -131,8 +130,7 @@ static void pc_q35_init(MachineState *machine)
>>>           rom_memory = get_system_memory();
>>>       }
>>>
>>> -    guest_info = pc_guest_info_init(pcms);
>>> -    guest_info->isapc_ram_fw = false;
>>
>> This may not be an issue, I just want be sure.
>> For Q35 isapc_ram_fw is always false, but now we are always querying
>> !pcmc->pci_enabled.
>>
>> Now we have a Q35 case when !pcmc->pci_enabled *can* be true.
>
> Do we? pcmc->pci_enabled is always true in Q35.

OK, thanks, so all the pcmc->pci_enabled "if" clauses in pc_q35_init are not necessary, right?
Anyway, this is no connected tot his patch.


Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Thanks,
Marcel

>