From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934527AbbLQNqP (ORCPT ); Thu, 17 Dec 2015 08:46:15 -0500 Received: from mail.bmw-carit.de ([62.245.222.98]:56312 "EHLO mail.bmw-carit.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932318AbbLQNqO (ORCPT ); Thu, 17 Dec 2015 08:46:14 -0500 X-CTCH-RefID: str=0001.0A0C0202.5672BC9A.0037,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Subject: Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations To: "Wangnan (F)" , , , , , , , , , , , References: <1450329794-161948-1-git-send-email-wangnan0@huawei.com> <56725868.6080902@bmw-carit.de> <56725B67.2010309@huawei.com> <56725E59.6090507@bmw-carit.de> <56727259.80002@bmw-carit.de> <567289D6.9050209@huawei.com> CC: , From: Daniel Wagner X-Enigmail-Draft-Status: N1110 Message-ID: <5672BC99.4070605@bmw-carit.de> Date: Thu, 17 Dec 2015 14:46:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <567289D6.9050209@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/17/2015 11:09 AM, Wangnan (F) wrote: > On 2015/12/17 16:29, Daniel Wagner wrote: >> On 12/17/2015 08:03 AM, Daniel Wagner wrote: >> Patch number 2 didn't apply cleanly. > > Because I have another patch in my local tree which also modifis bpf > Makefile: > > http://lkml.kernel.org/g/1450316632-152513-1-git-send-email-wangnan0@huawei.com > > sorry. Ah, that explains it this problem. >> After fixing this manually >> I was able to continue to the build step: >> >> $ make samples/bpf/ >> CHK include/config/kernel.release >> CHK include/generated/uapi/linux/version.h >> CHK include/generated/utsrelease.h >> CHK include/generated/bounds.h >> CHK include/generated/timeconst.h >> CHK include/generated/asm-offsets.h >> CALL scripts/checksyscalls.sh >> make -C /home/wagi/src/linux/tools/lib/bpf >> O=/home/wagi/src/linux/samples/bpf/libbpf CFLAGS= LDFLAGS= V=1 >> /home/wagi/src/linux/samples/bpf/libbpf/libbpf.a >> No libelf found >> Makefile:203: recipe for target 'elfdep' failed >> make[2]: *** [elfdep] Error 255 >> samples/bpf/Makefile:10: recipe for target >> 'samples/bpf/libbpf/libbpf.a' failed >> make[1]: *** [samples/bpf/libbpf/libbpf.a] Error 2 >> Makefile:1550: recipe for target 'samples/bpf/' failed >> make: *** [samples/bpf/] Error 2 > > When you see this, could you please have a look at: > > /home/wagi/src/linux/samples/bpf/libbpf/feature/test-*.make.output > > ? test-libpython.c:1:20: fatal error: Python.h: No such file or directory $ find /usr/include -name Python.h /usr/include/python3.4m/Python.h /usr/include/python2.7/Python.h Adding a symlink to /usr/include/Python.h to /usr/include/python2.7/Python.h didn't help. > This error means it can't find libelf on your platform, but it is not > true obviously. Yeah look like. Funny thing though is if I build libelf directly $ make -C tools/lib/bpf/ make: Entering directory '/home/wagi/src/linux/tools/lib/bpf' Auto-detecting system features: ... libelf: [ on ] ... bpf: [ on ] CC fixdep.o LD fixdep-in.o LINK fixdep CC libbpf.o CC bpf.o LD libbpf-in.o LINK libbpf.a LINK libbpf.so make: Leaving directory '/home/wagi/src/linux/tools/lib/bpf' all is fine. >> fds_example.c:(.text.startup+0x20e): undefined reference to >> `bpf_pin_object' >> fds_example.c:(.text.startup+0x2b0): undefined reference to >> `bpf_pin_object' >> fds_example.c:(.text.startup+0x2f3): undefined reference to >> `bpf_get_pinned_object' >> fds_example.c:(.text.startup+0x344): undefined reference to >> `bpf_get_pinned_object' >> collect2: error: ld returned 1 exit status >> > > Could you please check whether this patch: > > bpf tools: Support BPF_OBJ_PIN and BPF_OBJ_GET > > is applied properly? No it wasn't. Sorry about that one. I didn't pay enough attention when applying them. The v2 of 6 did upset my workflow.