From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] tty: amba-pl011: add support for 32-bit register access for earlycon Date: Thu, 17 Dec 2015 10:47:56 -0600 Message-ID: <5672E73C.20601@codeaurora.org> References: <1446855503-25881-1-git-send-email-timur@codeaurora.org> <20151213060643.GA30667@kroah.com> <20151217162736.GA5897@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151217162736.GA5897@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Greg Kroah-Hartman Cc: Peter Hurley , Andre Przywara , Linus Walleij , Andrew Jackson , cov@codeaurora.org, linux-serial@vger.kernel.org, jslaby@suse.com, Russell King , Jun Nie , "linux-arm-kernel@lists.infradead.org" List-Id: linux-serial@vger.kernel.org Greg Kroah-Hartman wrote: >> >There was some disagreement about the usage of >> >access_32b vs uap->port.iotype for determining whether we need 32-bit >> >accessors or not. > There was? I missed that, please send follow-on patches to resolve the > issue if there is one. I can submit a patch that provides an alternative implementation, but I'm pretty sure Russell won't like it. For reference: http://www.spinics.net/lists/linux-serial/msg19710.html Russell said that UPIO_MEM is supposed to be literally only 8-bit access, but then Peter Hurley posted this: http://www.spinics.net/lists/linux-serial/msg19930.html which you applied. So my patch would remove access_32b and use UPIO_MEM32/UPIO_MEM instead. It would be a little weird having both patches in your tree, I guess. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation. From mboxrd@z Thu Jan 1 00:00:00 1970 From: timur@codeaurora.org (Timur Tabi) Date: Thu, 17 Dec 2015 10:47:56 -0600 Subject: [PATCH] tty: amba-pl011: add support for 32-bit register access for earlycon In-Reply-To: <20151217162736.GA5897@kroah.com> References: <1446855503-25881-1-git-send-email-timur@codeaurora.org> <20151213060643.GA30667@kroah.com> <20151217162736.GA5897@kroah.com> Message-ID: <5672E73C.20601@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Greg Kroah-Hartman wrote: >> >There was some disagreement about the usage of >> >access_32b vs uap->port.iotype for determining whether we need 32-bit >> >accessors or not. > There was? I missed that, please send follow-on patches to resolve the > issue if there is one. I can submit a patch that provides an alternative implementation, but I'm pretty sure Russell won't like it. For reference: http://www.spinics.net/lists/linux-serial/msg19710.html Russell said that UPIO_MEM is supposed to be literally only 8-bit access, but then Peter Hurley posted this: http://www.spinics.net/lists/linux-serial/msg19930.html which you applied. So my patch would remove access_32b and use UPIO_MEM32/UPIO_MEM instead. It would be a little weird having both patches in your tree, I guess. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.