From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755811AbbLQTO2 (ORCPT ); Thu, 17 Dec 2015 14:14:28 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:19518 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755772AbbLQTOZ (ORCPT ); Thu, 17 Dec 2015 14:14:25 -0500 Subject: Re: [PATCH] use callbacks to access UART_DLL/UART_DLM To: Mans Rullgard Cc: Sebastian Frias , Greg Kroah-Hartman , Magnus Damm , linux-serial@vger.kernel.org, LKML References: <5672D89A.4090307@laposte.net> <5672F9C9.1010601@laposte.net> From: Mason Message-ID: <56730985.1080609@free.fr> Date: Thu, 17 Dec 2015 20:14:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/12/2015 19:09, Måns Rullgård wrote: > It could well be that your patch results in a clearer final version, but > the diff is harder to parse when unchanged lines have moved around. When all other things are equal, is the priority 1) making the patch as clear as possible? 2) making the resulting code as clear as possible? On a related note, I remember spotting a problem in a phy driver commit, and was told (by you) that I should split my fix in 3 (!!) patches. I'm sorry, but that's a double standard, why would the initial committer be given the leeway to post a single patch, but someone willing to clean up his mess should work harder? End result: I left the bug in there. Regards.